keepalives: only queue keepalive when queue is empty

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

1 files changed, 9 insertions, 6 deletions

diff --git a/src/send.c b/src/send.c
index 1f63fd9..e1d8010 100644
--- a/src/send.c
+++ b/src/send.c
@@ -110,12 +110,15 @@ static inline void keep_key_fresh(struct wireguard_peer *peer)
 
 void packet_send_keepalive(struct wireguard_peer *peer)
 {
-	struct sk_buff *skb = alloc_skb(DATA_PACKET_HEAD_ROOM + MESSAGE_MINIMUM_LENGTH, GFP_ATOMIC);
-	if (unlikely(!skb))
-		return;
-	skb_reserve(skb, DATA_PACKET_HEAD_ROOM);
-	skb->dev = netdev_pub(peer->device);
-	skb_queue_tail(&peer->tx_packet_queue, skb);
+	struct sk_buff *skb;
+	if (!skb_queue_len(&peer->tx_packet_queue)) {
+		skb = alloc_skb(DATA_PACKET_HEAD_ROOM + MESSAGE_MINIMUM_LENGTH, GFP_ATOMIC);
+		if (unlikely(!skb))
+			return;
+		skb_reserve(skb, DATA_PACKET_HEAD_ROOM);
+		skb->dev = netdev_pub(peer->device);
+		skb_queue_tail(&peer->tx_packet_queue, skb);
+	}
 	packet_send_queue(peer);
 }