diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-04-21 17:03:25 -0600 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-06-04 16:57:59 +0200 |
| commit | 3c14c4bf90f37ad5d0bc6e0e0e7972f9ae4ad3ed (patch) | |
| tree | 1cf656b218d5470c75ff738d5f9873fc1d39bfee | |
| parent | 4d8b7edca7c1cc7894007cd378acb30e870d90f5 (diff) | |
allowedips: initialize list head in selftest
The randomized trie tests weren't initializing the dummy peer list head,
resulting in a NULL pointer dereference when used. Fix this by
initializing it in the randomized trie test, just like we do for the
static unit test.
While we're at it, all of the other strings like this have the word
"self-test", so add it to the missing place here.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| -rw-r--r-- | src/selftest/allowedips.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/selftest/allowedips.c b/src/selftest/allowedips.c index 846db14..0d2a43a 100644 --- a/src/selftest/allowedips.c +++ b/src/selftest/allowedips.c @@ -296,6 +296,7 @@ static __init bool randomized_test(void) goto free; } kref_init(&peers[i]->refcount); + INIT_LIST_HEAD(&peers[i]->allowedips_list); } mutex_lock(&mutex); @@ -333,7 +334,7 @@ static __init bool randomized_test(void) if (wg_allowedips_insert_v4(&t, (struct in_addr *)mutated, cidr, peer, &mutex) < 0) { - pr_err("allowedips random malloc: FAIL\n"); + pr_err("allowedips random self-test malloc: FAIL\n"); goto free_locked; } if (horrible_allowedips_insert_v4(&h, |