| Age | Commit message (Collapse) | Author |
|---|
|
Explicitly zero-initialize `obi` in `_args_get()` to avoid the following
compiler warning:
.../ubus.c: In function ‘_args_get’:
.../ubus.c:100:31: error: ‘obj’ may be used uninitialized [-Werror=maybe-uninitialized]
100 | arg = ucv_object_get(obj, name, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Calling ubus.defer() outside of uloop.run() was apparently broken since commit
1cb04f9b76e2 ("ubus: add object publishing, notify and subscribe support") from
March 2022.
It was supposed to block until the request completes, however it blocked forever
due to a counter imbalance introduced by the above commit.
These days this 'feature' is of questionable value, since req.await() exists,
and there is a legitimate use for issuing deferred requests from outside of
uloop.run() and then calling uloop.run() or req.await() afterwards.
Since nobody noticed the breakage in all this time, let's just get rid of
this API footgun.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
When passing UBUS_STATUS_CONTINUE (or -1) in the return code argument, assume
that more reply calls are coming and only send a reply data message without
the status code.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
[minor whitespace changes]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Works in the same way as regular defer calls, except that it operates on
channels.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
[use errval_return(), minor whitespace changes]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Add a local helper macro errval_return() which sets a local error code
and returns it. Also do some minor whitespace and code style fixes while
we're at it.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
socket: add missing documentation for socket.listen() reuseaddr
|
|
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
uci: add support for altering the override config directory
|
|
This was added to libuci recently
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
This socket option needs to be set before the bind call(). Since it's very
commonly used, adding a parameter for it makes sense.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
Support passing integer object instead of string in ubus.call(). This makes it
possible to query ACL data:
let data = ubus.call(libubus.SYSTEM_OBJECT_ACL, "query");
Signed-off-by: Felix Fietkau <nbd@nbd.name>
[adjust formatting, rebase]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
In order to make the nested uci.cursor class description easier to
discover, turn the mentioned `save()` and `commit()` functions into proper
links pointing into the cursor class documentation.
Ref: #277
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Thibaut VARÈNE <hacks@slashdirt.org>
|
|
Signed-off-by: Thibaut VARÈNE <hacks@slashdirt.org>
|
|
No functional change
Signed-off-by: Thibaut VARÈNE <hacks@slashdirt.org>
|
|
Prepare for stream-oriented operations
Signed-off-by: Thibaut VARÈNE <hacks@slashdirt.org>
|
|
Introduce two new functions list_append(conf, section, option, value) and
list_remove(conf, section, option, value) which add and remove values from
uci list options, respectively.
Fixes: #279
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
fs: improve ioctl implementation
|
|
ubus file descriptor passing and channel support
|
|
A channel is a context that is directly connected to a peer instead of going
through ubusd. The use of this context is limited to calling ubus_invoke and
receiving requests not bound to any registered object.
The main use case for this is having a more stateful interaction between
processes. A service using channels can attach metadata to each individual
channel and keep track of its lifetime, which is not possible through
the regular subscribe/notify mechanism.
Using channels also improves request latency, since messages are passed
directly between processes.
A channel can either be opened by fd using ubus.open_channel(), or created
from within a request by using req.new_channel(). When calling req.new_channel,
the fd for the other side of the channel is automatically passed to the
remote caller.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
Add a named parameter fd_cb, which is called when the callee returned a
file descriptor.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
File descriptors can be passed via the named fd argument
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
This can be used to send and receive file descriptors from within an object
method call.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
This can be used to synchronously complete a deferred ubus request,
waiting for completion or timeout.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
Allocate memory for 'uc_string_t' with the proper size upfront and
use it's internal buffer as ioctl buffer. This avoids redundant
'ucv_string_new_length' calls and thus allocating memory a second time.
Also simplify the signature of the function, using a single parameter
for handling size and input buffer values.
Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
[simplify arguments, adjust documentation, prevent in-place string
modifications]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Exports IOC_DIR_* constants to use for the direction parameter instead
of plain integer values. The constants are based on the target's _IOC_*
definitions.
Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
|
|
When a function supports many parameters, the order can be somewhat
confusing, especially when dealing with several optional ones.
In order to make this easier to use, support for passing an object with
named parameters.
for example:
obj.notify("test", data, null, null, null, 1000);
can be written as:
obj.notify({
method: "test",
data,
timeout: 1000
});
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
The SO_ATTACH_FILTER socket option requires special handling as it is not
passing a self-contained structure to the kernel but a pointer to user
memory holding the actual BPF bytecode.
In order to properly support this, first rework the ucode value to C struct
conversion callback machinery to pass an indirect struct base pointer,
allowing conversion callbacks to realloc the struct memory as needed.
Finally introduce custom uv to C conversion for the BPF data which accepts
either a raw bytecode string, an array of opcode arrays or a flat array of
opcode values which are converted into a C array of struct sock_filter
records appended to the reallocated struct memory.
Attaching a BPF program equivalent to the tcpdump expression
`vlan 20 && ether proto 0x1234` would then look like this:
sock.setopt(SOL_SOCKET, SO_ATTACH_FILTER, {
filter: [
[ 0x28, 0, 0, 0x0000000c ],
[ 0x15, 2, 0, 0x00008100 ],
[ 0x15, 1, 0, 0x000088a8 ],
[ 0x15, 0, 6, 0x00009100 ],
[ 0x28, 0, 0, 0x0000000e ],
[ 0x54, 0, 0, 0x00000fff ],
[ 0x15, 0, 3, 0x00000014 ],
[ 0x28, 0, 0, 0x00000010 ],
[ 0x15, 0, 1, 0x00001234 ],
[ 0x6, 0, 0, 0x00040000 ],
[ 0x6, 0, 0, 0x00000000 ],
]
});
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Avoid re-invoking any event listener callbacks after an invocation
triggered an exception in order to avoid accidentially clearing the
exception information.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
- Do not unconditionally pass the `MSG_CMSG_CLOEXEC` flag to `recvmsg()`
invocations as not all protocol specific recvmsg implementations in the
kernel tolerate it; `packet_recvmsg()` for example will immediately
return yield `EINVAL` if any non-whitelisted flag is passed.
- Ensure that the HW address string buffer is zero-terminated when
converting MAC addresses from C to ucode values.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Do not increase the refcount when returning the pulled buffer contents
as string since the returned value already is the sole reference.
Without this change, pulled buffer contents will be leaked whenever
the `pull()` function is used.
Also ensure that the buffer memory is completely zero initialized when
it is allocated from scratch, the existing logic only cleared the trailing
data area on reallocations but never the head on fresh allocations.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Use the VM registry to store the last uci error code and lookup the uci
cursor resource type at resource creation time instead of caching it in
a global variable.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Drop the usage of global static variables for caching the per-VM resource
type objects in order to properly support loading the library in multiple
concurrent threads or VM instances.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Implement a new struct buffer API to support incremental packing and
unpacking of binary data. This API allows for more flexible and efficient
handling of structured data, especially for streaming or partial
processing scenarios.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
When performing a `NL80211_CMD_GET_WIPHY` request for a single wiphy with
`split_wiphy_dump` set to true, the expectation is that only a single phy
object is returned, like when performing the same request without splitting,
yet the current implementation returns a sparse array with only the
requested phy index populated instead.
Fix this issue by special-casing NL80211_CMD_GET_WIPHY command requests
with a set `split_wiphy_dump` attribute. Also implicitly set the
`NLM_F_DUMP` flag in this case as it is required for the kernel to send
all information.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
lib: Removed global variables from module fs for thread safety
|
|
Introduce a new default enabled CMake option `DIGEST_SUPPORT_EXTENDED`
which, when turned off, disables all but the most common md5, sha1 and
sha256 alogirthms to reduce the library size.
Also prefer statically linking libmd if possible.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Sebastian Ertz <sebastian.ertz@gmx.de>
|
|
Move last error code into a VM registry value and lookup resource types
within the current VM context at call time, allowing the proper use of
the fs module within multiple threads of a multithreaded application.
Suggested-by: Isaac de Wolff <idewolff@vincitech.nl>
[turn err_return() back into a local macro, simplify uc_fs_error(),
align whitespace style]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
- vif radio mask: used to assign vifs to specific radios
- monitor skip_tx flag: do not pass locally transmitted packets on the monitor interface
- radio antenna mask: radio specific part of the phy antenna mask
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
These new attributes are required when dealing with WiFi 7 radios.
Reported-by: John Crispin <john@phrozen.org>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
lib: Removed global variables from module math for thread safety
|
|
utils: improve vector macros
|
|
Signed-off-by: Sebastian Ertz <sebastian.ertz@gmx.de>
|
|
Utilize uc_vector_push() and uc_vector_foreach() where applicable.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
The `fanout_args` structure is a relatively recent addition to the kernel
so provide a local definition for it, like we already do it for other like
`timeval_old`.
Fixes: #217
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Make sure to free the line buffer pointer when aborting a
`getline()` / `getdelim()` based read operation on i/o errors.
As an example, this issue could be triggered by receiving a broken
pipe error while attempting to read a line from stdin.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Chad Monroe <chad@monroe.io>
|
|
implements ioctl() for a given file handle on Linux.
Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
|
|
The mac80211_hwsim module exposes a custom generic netlink family for
managing simulated phys and userspace data frame transmission.
Since hwsim functionality is closely related to nl80211 and useful to
e.g. manage simulated wireless testbeds, I decided to include support
directly into the nl80211 module.
Example calls for creating and destroying hwsim wiphys:
nl80211.request(nl80211.const.HWSIM_CMD_NEW_RADIO, 0, {
perm_addr: "02:11:22:33:44:55",
support_p2p_device: true
});
nl80211.request(nl80211.const.HWSIM_CMD_DEL_RADIO, 0, {
radio_name: "phy2"
});
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
