diff options
author | Isaku Yamahata <yamahata@valinux.co.jp> | 2013-03-28 16:08:11 +0900 |
---|---|---|
committer | FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> | 2013-03-28 19:34:17 +0900 |
commit | d3970faeabfc886a4524bc8ce73461f8ab532998 (patch) | |
tree | 79ec172a23d0b713f296372e1242d93bf209d0eb | |
parent | 65aba138643cbefc7175b3013c2807c22e21c001 (diff) |
lib/packet/packet_base: fix signature of PacketBase.{parser, serialize}
All subclasses define them as
parser(cls, buf) and serialize(self, payload, prev)
Not parser(cls), serialize(self).
pylint also complains like
> W: 50,4:ipv4.parser: Arguments number differs from overridden method
> W: 65,4:ipv4.serialize: Arguments number differs from overridden method
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
-rw-r--r-- | ryu/lib/packet/packet_base.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py index 437678b3..aa38eb03 100644 --- a/ryu/lib/packet/packet_base.py +++ b/ryu/lib/packet/packet_base.py @@ -31,8 +31,8 @@ class PacketBase(object): self.protocol_name = self.__class__.__name__ @classmethod - def parser(cls): + def parser(cls, buf): pass - def serialize(self): + def serialize(self, payload, prev): pass |