summaryrefslogtreecommitdiffhomepage
path: root/modules/luci-mod-network
AgeCommit message (Collapse)Author
2021-09-23luci-mod-network: fix name of network.device.isolate uci optionJo-Philipp Wich
Fixes: #5383 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-09-04luci-mod-network: fix route and rule optionsVladislav Grigoryev
Allow adding routes with unspecified interface. This is required for prohibit, blackhole and unreachable routes. Allow adding routes with loopback interface. This can work as a blackhole route. Fix netmask to prefix conversion for the routes. Identify the IP family by the UCI section type. Avoid setting the routing table textvalue for the rules. The rules should target none table unless specified otherwise. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-09-03Merge pull request #5008 from mpratt14/vlan-defaultFlorian Eckert
luci-mod-network: do not remove enable_vlan from config
2021-09-01luci-mod-network: network/routing support for pbrVladislav Grigoryev
Provide comprehensive routing configuration: * Rename the "Network > Routes" page to "Network > Routing". * Unify sorting for the "Status" and "Network" menus. * Add the tabs "IPv4 Rules" and "IPv6 Rules" to the "Routing" page. * Provide configuration for IPv4 and IPv6 routing rules. * Consolidate routing configuration and terminology for IPv4 and IPv6. Policy-based routing is an increasingly popular problem. Netifd natively supports policy-based routing: * Interface-specific options "ip4table" and "ip6table". * Routing rules using the "rule" and "rule6" sections. LuCI is missing configuration for routing rules. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-08-31Merge pull request #5301 from vgaetera/fix-iface-ip6tableJo-Philipp Wich
2021-08-31luci-mod-network: clarify device settings "Delete" buttonSven Roederer
Use proper label text "Unconfigure" for button which "Remove related device settings". Ref: #5090, #5092 Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
2021-08-31Merge pull request #5296 from vgaetera/dhcp-labelsFlorian Eckert
luci-mod-network: update dhcp and dns labels and descriptions
2021-08-30luci-mod-network: update dhcp and dns labels and descriptionsVladislav Grigoryev
Update labels and descriptions for DHCP and DNS settings. Add missing descriptions and clarify the existing ones. Group settings by tab and avoid redundant abbreviations. Consolidate terminology according to the dnsmasq documentation: https://thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html Fix spelling according to the previously adopted policy: https://github.com/openwrt/luci/commit/88b9d843882cf52a6acf4d08a878fd005120edd4 Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-08-26luci-mod-network: fix route6 source autocompleteVladislav Grigoryev
Fix the wrong value for the "source" option of the "route6" section. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-08-26luci-mod-network: fix option ip6table in network/interfacesVladislav Grigoryev
Fix the incorrectly displayed value for the option "ip6table". Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-08-11network: hide dnamsq (dhcp+dns) itemFritz D. Ansel
.. when no dnsmasq is installed, as it tells only that there are no settings available Signed-off-by: Fritz D. Ansel <fdansel@yandex.ru>
2021-08-09luci-mod-network: merge hosts with dns settingsVladislav Grigoryev
The current location for "Network > Hostnames" is confusing. It is provided by Dnsmasq and partly overlaps with static leases. Merge "Hostnames" with "Network > DHCP and DNS" as an extra tab. Also add a simple explanation of the use case. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com> [Fix typo in label description string] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-08-09luci-mod-network: fix legacy_rates option dependencyJo-Philipp Wich
The recently introduced band option support changed the internal frequency selector choice values, breaking the legacy rates option dependency. Fixes: #5234 Fixes: 0829d31290 ("luci-mod-network: support newer wireless.wifi-device.band option") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-09luci-mod-network: fix 60GHz radio frequency configurationJo-Philipp Wich
Fix incorrect minimum 60GHz frequency value and ensure that a 60GHz band choice option is available once corresponding channels are found on the system. Ref: http://lists.openwrt.org/pipermail/openwrt-devel/2021-July/035810.html Suggested-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-08luci-mod-network: dhcp.js: don't fail on not existing interfaceJo-Philipp Wich
Fixes: #5177 Fixes: 7e56289538 ("luci-mod-network: improve static DHCP lease validation") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-03luci-mod-network: fixes to DHCP lease validationJo-Philipp Wich
- validate current form value IP instead of stored uci one - ensure to not pass non-string values to the validator - remove leftover debug code - simplify obtaining formvalues Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-03luci-mod-network: improve static DHCP lease validationJo-Philipp Wich
- Ensure that MAC addresses are unique within the same pool - Ensure that IP addresses are globally unique - Ensure that IP addresses are within any DHCP pool range Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-03Revert "luci-mod-network: issue with breakdown of dnsmasq after duplication ↵Jo-Philipp Wich
of static IP was fixed" This reverts commit 463e910119813aaea0755ff5c16c91ce412a8cbb. This change causes the entire static lease to get deleted when attempting to change the MAC address. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-02luci-mod-network: fix saving bridge VLANs without member portsJo-Philipp Wich
Calling `uci.set()` with an empty array yields an invalid argument error, make sure to pass `null` instead in this case. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-02luci-mod-network: work around jsmin bugJo-Philipp Wich
The jsmin minifier incorrectly transforms the expression `/\*/.test(...)` into `/\* /.test(...)`, causing the VLAN filter dialog to not recognize PVID settings in the configuration. Work around the issue by using an equivalent `\x2a` escape sequence instead. Ref: https://forum.openwrt.org/t/x/99222/28 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-30luci-mod-network: enforce IPv4 mode for traceroute callJo-Philipp Wich
Recent busybox traceroute applet versions support both IPv4 and IPv6 and default to IPv6 when running a route trace to an IPv6 enabled target host. Pass the `-4` flag to enforce IPv4 mode in this case. Fixes: #5155 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-21Merge pull request #4965 from tano-systems/pr/20210406-disable-routes-supportFlorian Eckert
luci-mod-network: Support for disabling routes
2021-06-21treewide: fix typo in "Enable VLAN filtering" labelJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: parse ports without tag/pvid annotation as wellJo-Philipp Wich
Fixes: 01eac366f6 ("luci-mod-network: fix tagging/pvid state parsing in bridge-vlan ports") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: fix tagging/pvid state parsing in bridge-vlan portsJo-Philipp Wich
The previous code naively looked for a `t` in the entire port spec, wrongly matching untagged ports having a `t` in their name, such as `eth0`. Rework the logic to be more strict when parsing the port member specification to avoid this issue. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: refactor device configurationJo-Philipp Wich
Since all netifd device types inherit generic device settings, we can simplify various aspects of the device configuration ui and drop unused code while we're at it. - Remove setIfActive() helper, superseded by commit f3f74bd0fe ("luci-base: form.js: consider aliased options in AbstractValue.remove()") - Remove most dependency constraints to make all generic device settings available for all device types - Add MTU value validation to disallow exceeding parent device MTU for VLAN interfaces - Dynamically update placeholder values when changing base or parent device options - Undo VLAN network config hack since all options are available now. Reverts commit 3c6b59504a ("luci-mod-interfaces: simplify configuring MAC address of 802.1q devices") - Do not suggest inactive wireless networks as existing device or base device choices - Disallow specifying names of already existing network devices when creating new device settings - Fix a number of multicast dependency specifications - Drop now unused functions Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: change port status layout in vlan filter configJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: only consider bridge vlans belonging to the current deviceJo-Philipp Wich
In case multiple bridges with bridge vlans are declared, LuCI did not correctly filter the VLANs to show only the ones belonging to the bridge being configured currently. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-14luci-mod-network: wireless.js: recognize HE* htmodesJo-Philipp Wich
Ref: https://bugs.openwrt.org/index.php?do=details&task_id=3856#comment9797 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-13luci-mod-network: small styling fixes for vlan filter matrixJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-12luci-mod-network: migrate more device optionsRafał Miłecki
Include mtu and igmp_snooping while migrating. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-06-12luci-mod-network: reset bridge VLANs on cancelling modal dialogJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-12luci-mod-network: fix vlan filter matrix overflow after redrawJo-Philipp Wich
Ensure that the overflow styles are reapplied after a redraw. This also simplifies the code as a side-effect. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-11luci-mod-network: add port status to bridge vlan filter matrixJo-Philipp Wich
Also ensure that port devices are ordered numerically. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-09luci-mod-network: fix horizontal scrolling in the bridge vlan filter matrixJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-09Merge pull request #5110 from jow-/wireless-band-optionJo-Philipp Wich
luci-mod-network: support newer wireless.wifi-device.band option
2021-06-09luci-mod-network: interfaces.js: fix ifname migration in device sectionsJo-Philipp Wich
The migration code attempted to add new device sections instead of moving the ifname option to a ports list within the existing ones. Fixes: #5108 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-09luci-mod-network: interfaces: show bridge port device icons againJo-Philipp Wich
Restore the display of bridge port device icons in the interface overviews. This feature has been lost after migrating the network config from legacy bridge declarations to device bridge declarations. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-09luci-mod-network: support newer wireless.wifi-device.band optionJo-Philipp Wich
OpenWrt switched from "option hwmode" to "option band" in order to select the frequency band to use for the radio phy. Extend the channel selector to recognize and use an existing "option band" to select the appropriate channel list. When operating upon a wireless configuration still using "option hwmode", then translate it to a band value internally and translate it back to "option hwmode" on save. This should provide forward- and backwards compatibility with both current OpenWrt master and older versions still using hwmode. Fixes: #5106 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-07treewide: consolidate {IPv4,IPv6,MAC} {address,gateway} spellingsJo-Philipp Wich
- Turn IPv4-Address into IPv4 address - Turn IPv4-Gateway into IPv4 gateway - Turn IPv6-Address into IPv6 address - Turn IPv6-Gateway into IPv6 gateway - Turn MAC-Address into MAC address Also remove related duplicate translation entries. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-07treewide: fix "promiscious" typoJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-05Merge pull request #5095 from jow-/dhcpv6-reworkJo-Philipp Wich
luci-mod-network: interfaces: restructure DHCPv6 and IPv6 RA options
2021-06-05Merge pull request #5070 from blocktrron/pr-luci-wifi6David Bauer
luci-mod-network: add 802.11ax HE support
2021-06-05luci-mod-network: allow device declarations and device configs to coexistJo-Philipp Wich
It is legal to have two device sections referring to the same netdev if one section is a declaration (a section setting option type) and the other is a configuration (a section not specifying a type but matching an existing netdev). Support this case in LuCI since it might be required for some complex device setups. Additionally, fix the device type determination for device configuration sections without type, those should be treated as ethernet (a.k.a. simple device) configuration instead of falling back to the underlying netdev device type. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-05luci-mod-network: add 802.11ax HE supportDavid Bauer
This commit adds the ability to configure HE-modes for radios (HE20 / HE40 / HE80 / HE160) as well as HE rate information in the assiciation view. Tested-on: Ubiquiti UniFi 6 Lite / LR Signed-off-by: David Bauer <mail@david-bauer.net>
2021-06-05luci-mod-interfaces: simplify configuring MAC address of 802.1q devicesJo-Philipp Wich
Treat not explicitly configured, preexisting VLAN interfaces as simple network devices when adding configuration for them, since it is more likely that people want to set general device properties such as MAC address instead of reconfiguring ingress/egress QoS mapping, which is the only editable property of preexisting VLAN device config dialogs. Ref: https://github.com/openwrt/luci/issues/5102 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-03luci-mod-network: interfaces: restructure DHCPv6 and IPv6 RA optionsJo-Philipp Wich
- Condense overly large IPv6 RA/DHCPv6 description texts and get rid of most embedded markup - Switch ra/ndp/dhcpv6 mode selections to rich dropdown lists and move extended choice descriptions next to the selection options - Drop ndproxy_static option which has been removed from odhcpd long ago - Add format validations to all text input fields - Add ability to configure master/relay modes for non-static interfaces (#2998) - Move extended RA configuration options into a new tab - Prevent enabling master mode on multiple interfaces - Prevent enabling ra/dhcpv6 server mode on non-static or master interfaces - Drop ra_management in favor to ra_flags option (#5083) - Add support for dns_service option - Read current effective IPv6 MTU and hop limit placeholder values from procfs Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-03treewide: Update JS using luci-rpc getHostHintsNiels Widger
Update frontend JS code which uses luci-rpc getHostHints to support the new response format which removes the `ipv4` and `ipv6` host hint string fields and replaces them with `ipaddrs` and `ip6addrs` weighted string list fields. Signed-off-by: Niels Widger <niels@qacafe.com> [rework code to be forwards/backwards compatible, fix some Network.Hosts methods, fix IP choice ordering, change commit subject, rewrap commit message] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-01luci-mod-network: rename "device" option to "_net_device" internallyJo-Philipp Wich
This is required to resolve conflicts with the existing "device" option in other proto handlers such as PPP or QMI where "device" refers to the device path of the tty control device instead of a netdev name. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-01luci-mod-network: clarify device settings reset button tooltipJo-Philipp Wich
Ref: #5090 Signed-off-by: Jo-Philipp Wich <jo@mein.io>