diff options
| author | Hauke Mehrtens <hauke@hauke-m.de> | 2021-06-09 01:28:44 +0200 |
|---|---|---|
| committer | Hauke Mehrtens <hauke@hauke-m.de> | 2021-06-09 01:33:44 +0200 |
| commit | 5cbd79d7e31c0f0feaea2770bf102bbae7831e3c (patch) | |
| tree | ac1d330cb1d8ecb385ccaad940ee5e4b6e685783 /themes/luci-theme-material | |
| parent | da97288015e0a8919c55075d71d88890e2f339f3 (diff) | |
themes: Call striptags() on hostname to prevent XSS
This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.
If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.
This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Diffstat (limited to 'themes/luci-theme-material')
| -rw-r--r-- | themes/luci-theme-material/luasrc/view/themes/material/header.htm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/themes/luci-theme-material/luasrc/view/themes/material/header.htm b/themes/luci-theme-material/luasrc/view/themes/material/header.htm index f81aae5ac1..8c418b6fc2 100644 --- a/themes/luci-theme-material/luasrc/view/themes/material/header.htm +++ b/themes/luci-theme-material/luasrc/view/themes/material/header.htm @@ -190,7 +190,7 @@ <div class="container"> <span class="showSide"></span> <a id="logo" href="<% if luci.dispatcher.context.authsession then %><%=url('admin/status/overview')%><% else %>#<% end %>"><img src="<%=media%>/brand.png" alt="OpenWrt"></a> - <a class="brand" href="#"><%=boardinfo.hostname or "?"%></a> + <a class="brand" href="#"><%=striptags(boardinfo.hostname or "?")%></a> <div class="status" id="indicators"> <span id="xhr_poll_status" style="display:none" onclick="XHR.running() ? XHR.halt() : XHR.run()"> <span class="label success" id="xhr_poll_status_on"><span class="mobile-hide"><%:Auto Refresh%></span> <%:on%></span> |