diff options
| author | Preport <erdemgezzz@gmail.com> | 2024-11-14 23:07:05 +0300 |
|---|---|---|
| committer | Paul Donald <newtwen+github@gmail.com> | 2024-11-30 05:16:59 +0100 |
| commit | f3d26a2a560d8ae526c617eb1c28821ec900fa7a (patch) | |
| tree | 740caa70d2a4e711b9d37c99eabd5a32552e0440 /protocols/luci-proto-ppp/htdocs/luci-static/resources/protocol/pppoa.js | |
| parent | 4024dfa3020868638869316f43968e62697868e1 (diff) | |
luci-proto-3g/ppp/pppossh: fix being unable to set keepalive to 0
Since on openwrt keepalive option defaults to "5 1" when it's not
defined:
https://github.com/openwrt/openwrt/blob/6720c4ccba256186bf2f1b1edadb851c447e62a5/package/network/services/ppp/files/ppp.sh#L128
Users must be able to set it to 0 to ignore connection failures.
Signed-off-by: Erdem Gez <perport@perport.net>
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Diffstat (limited to 'protocols/luci-proto-ppp/htdocs/luci-static/resources/protocol/pppoa.js')
| -rw-r--r-- | protocols/luci-proto-ppp/htdocs/luci-static/resources/protocol/pppoa.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/protocols/luci-proto-ppp/htdocs/luci-static/resources/protocol/pppoa.js b/protocols/luci-proto-ppp/htdocs/luci-static/resources/protocol/pppoa.js index 0a5dc95788..b1f945caf9 100644 --- a/protocols/luci-proto-ppp/htdocs/luci-static/resources/protocol/pppoa.js +++ b/protocols/luci-proto-ppp/htdocs/luci-static/resources/protocol/pppoa.js @@ -11,13 +11,13 @@ function write_keepalive(section_id, value) { f = (f_opt != null) ? +f_opt[0].formvalue(section_id) : null, i = (i_opt != null) ? +i_opt[0].formvalue(section_id) : null; - if (f == null || f == '' || isNaN(f)) - f = 0; + if (f === '' || isNaN(f)) + f = null; if (i == null || i == '' || isNaN(i) || i < 1) i = 1; - if (f > 0) + if (f !== null) uci.set('network', section_id, 'keepalive', '%d %d'.format(f, i)); else uci.unset('network', section_id, 'keepalive'); |