summaryrefslogtreecommitdiffhomepage
path: root/modules
diff options
context:
space:
mode:
authorJo-Philipp Wich <jo@mein.io>2021-07-15 11:58:38 +0200
committerJo-Philipp Wich <jo@mein.io>2021-07-15 11:58:38 +0200
commit8d4ac60f7a02e5c8e3d186f4009b4696b098152d (patch)
tree7bcc693363049178152be9c34ac8f9f573a09062 /modules
parent7d9ab8d4a741cbc97e9553982e9e352b21ddf5f3 (diff)
luci-mod-system: reload crond upon saving crontab
Fixes: #5184 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Diffstat (limited to 'modules')
-rw-r--r--modules/luci-mod-system/htdocs/luci-static/resources/view/system/crontab.js6
-rw-r--r--modules/luci-mod-system/root/usr/share/rpcd/acl.d/luci-mod-system.json3
2 files changed, 5 insertions, 4 deletions
diff --git a/modules/luci-mod-system/htdocs/luci-static/resources/view/system/crontab.js b/modules/luci-mod-system/htdocs/luci-static/resources/view/system/crontab.js
index 939d41b0ec..079921a520 100644
--- a/modules/luci-mod-system/htdocs/luci-static/resources/view/system/crontab.js
+++ b/modules/luci-mod-system/htdocs/luci-static/resources/view/system/crontab.js
@@ -16,6 +16,8 @@ return view.extend({
return fs.write('/etc/crontabs/root', value).then(function(rc) {
document.querySelector('textarea').value = value;
ui.addNotification(null, E('p', _('Contents have been saved.')), 'info');
+
+ return fs.exec('/etc/init.d/cron', [ 'reload' ]);
}).catch(function(e) {
ui.addNotification(null, E('p', _('Unable to save contents: %s').format(e.message)));
});
@@ -24,9 +26,7 @@ return view.extend({
render: function(crontab) {
return E([
E('h2', _('Scheduled Tasks')),
- E('p', { 'class': 'cbi-section-descr' },
- _('This is the system crontab in which scheduled tasks can be defined.') +
- _('<br/>Note: you need to manually restart the cron service if the crontab file was empty before editing.')),
+ E('p', { 'class': 'cbi-section-descr' }, _('This is the system crontab in which scheduled tasks can be defined.')),
E('p', {}, E('textarea', { 'style': 'width:100%', 'rows': 10, 'disabled': isReadonlyView }, [ crontab != null ? crontab : '' ]))
]);
},
diff --git a/modules/luci-mod-system/root/usr/share/rpcd/acl.d/luci-mod-system.json b/modules/luci-mod-system/root/usr/share/rpcd/acl.d/luci-mod-system.json
index 38ff98dee6..c5f801a264 100644
--- a/modules/luci-mod-system/root/usr/share/rpcd/acl.d/luci-mod-system.json
+++ b/modules/luci-mod-system/root/usr/share/rpcd/acl.d/luci-mod-system.json
@@ -72,7 +72,8 @@
},
"write": {
"file": {
- "/etc/crontabs/root": [ "write" ]
+ "/etc/crontabs/root": [ "write" ],
+ "/etc/init.d/cron reload": [ "exec" ]
},
"ubus": {
"file": [ "write" ]