luci-mod-network: refactor device configuration

Since all netifd device types inherit generic device settings, we can
simplify various aspects of the device configuration ui and drop unused
code while we're at it.

 - Remove setIfActive() helper, superseded by commit
   f3f74bd0fe ("luci-base: form.js: consider aliased options in AbstractValue.remove()")

 - Remove most dependency constraints to make all generic device settings
   available for all device types

 - Add MTU value validation to disallow exceeding parent device MTU for
   VLAN interfaces

 - Dynamically update placeholder values when changing base or parent
   device options

 - Undo VLAN network config hack since all options are available now.
   Reverts commit
   3c6b59504a ("luci-mod-interfaces: simplify configuring MAC address of 802.1q devices")

 - Do not suggest inactive wireless networks as existing device or base
   device choices

 - Disallow specifying names of already existing network devices when
   creating new device settings

 - Fix a number of multicast dependency specifications

 - Drop now unused functions

Signed-off-by: Jo-Philipp Wich <jo@mein.io>

1 files changed, 0 insertions, 12 deletions

diff --git a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
index a8fa727da7..f7b8ddcafe 100644
--- a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
+++ b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
@@ -1258,18 +1258,6 @@ return view.extend({
 			if (m) {
 				var devtype = getDevType(section_id);
 
-				/* Treat not explicitly configured, preexisting VLAN interfaces
-				   as simple network devices when adding configuration for them,
-				   since it is more likely that people want to set general device
-				   properties such as MAC address instead of reconfiguring ingress/
-				   egress QoS mapping, which is the only editable property of
-				   preexisting VLAN device config dialogs.
-
-				   Ref: https://github.com/openwrt/luci/issues/5102
-				 */
-				if (devtype == '8021q')
-					devtype = 'ethernet';
-
 				section_id = uci.add('network', 'device');
 
 				uci.set('network', section_id, 'name', m[1]);