summaryrefslogtreecommitdiffhomepage
path: root/modules/luci-base
diff options
context:
space:
mode:
authorJo-Philipp Wich <jo@mein.io>2022-11-02 09:04:25 +0100
committerJo-Philipp Wich <jo@mein.io>2022-11-02 09:08:16 +0100
commitd967bbaa92ae56692ab449f57ca74f120943e799 (patch)
treeda5203f59b9bf3f7eac6bb6e1e62ac1ed2581dbf /modules/luci-base
parentda41c11971969913f34b28b7034cc4d986060d14 (diff)
luci-base: http.uc: fix invoking Lua file upload callbacks
In case a callback is installed from Lua code, the received callback argument is not a callable function but a resource object with a call method. Attempts to call it will leading to a `Type error: left-hand side is not a function` error. To solve this issue, invoke the internally set filehandler instead which wraps the resource if needed. Fixes: #6067 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Diffstat (limited to 'modules/luci-base')
-rw-r--r--modules/luci-base/ucode/http.uc2
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/luci-base/ucode/http.uc b/modules/luci-base/ucode/http.uc
index b464497eac..4856c47a0d 100644
--- a/modules/luci-base/ucode/http.uc
+++ b/modules/luci-base/ucode/http.uc
@@ -432,7 +432,7 @@ const Class = {
let data = value.fd.read(1024);
let eof = (data == null || data == '');
- callback(value, data, eof);
+ this.filehandler(value, data, eof);
if (eof) {
value.fd.close();