summaryrefslogtreecommitdiffhomepage
path: root/applications/luci-app-firewall/luasrc/view/firewall/cbi_addforward.htm
diff options
context:
space:
mode:
authorDirk Brenken <dev@brenken.org>2018-11-28 13:55:42 +0100
committerDirk Brenken <dev@brenken.org>2018-11-28 13:55:42 +0100
commit8db75255f7def8af500ecc6c711c66b8b17c78de (patch)
treefb8b8ce815691251753bb361c76832f6ad7d1ac3 /applications/luci-app-firewall/luasrc/view/firewall/cbi_addforward.htm
parent4bd7f4ba429eee697fb5f75c4ece5d03cc9514f5 (diff)
luci-app-firewall: remove hinting
Remove firewall hinting as discussed in #2340 Signed-off-by: Dirk Brenken <dev@brenken.org>
Diffstat (limited to 'applications/luci-app-firewall/luasrc/view/firewall/cbi_addforward.htm')
-rw-r--r--applications/luci-app-firewall/luasrc/view/firewall/cbi_addforward.htm20
1 files changed, 1 insertions, 19 deletions
diff --git a/applications/luci-app-firewall/luasrc/view/firewall/cbi_addforward.htm b/applications/luci-app-firewall/luasrc/view/firewall/cbi_addforward.htm
index 1bb86821ec..38f36b49c8 100644
--- a/applications/luci-app-firewall/luasrc/view/firewall/cbi_addforward.htm
+++ b/applications/luci-app-firewall/luasrc/view/firewall/cbi_addforward.htm
@@ -76,30 +76,12 @@
var n = document.getElementById('_newfwd.name');
var p = document.getElementById('_newfwd.proto');
var i = document.getElementById('_newfwd.intport');
- var hints = {
- /* port name 0=both, 1=tcp, 2=udp, 3=other */
- 21: [ 'FTP', 1 ],
- 22: [ 'SSH', 1 ],
- 53: [ 'DNS', 0 ],
- 80: [ 'HTTP', 1 ],
- 443: [ 'HTTPS', 1 ],
- 3389: [ 'RDP', 1 ],
- 5900: [ 'VNC', 1 ],
- };
if (!this.className.match(/invalid/))
{
if (!i.value) i.value = this.value;
- var hint = hints[this.value || 0] || hints[i.value || 0];
- if (hint)
- {
- p.selectedIndex = hint[1];
-
- if (!n.value)
- n.value = hint[0];
- }
- else if (!n.value)
+ if (!n.value)
{
n.value = 'Forward' + this.value;
}