Added netconf v4 tests and required modifiers

1 files changed, 18 insertions, 3 deletions

diff --git a/dhcpv4/dhcpv4_test.go b/dhcpv4/dhcpv4_test.go
index 059ae0c..283e728 100644
--- a/dhcpv4/dhcpv4_test.go
+++ b/dhcpv4/dhcpv4_test.go
@@ -347,9 +347,7 @@ func TestGetOption(t *testing.T) {
 
 func TestAddOption(t *testing.T) {
 	d, err := New()
-	if err != nil {
-		t.Fatal(err)
-	}
+	require.NoError(t, err)
 
 	hostnameOpt := &OptionGeneric{OptionCode: OptionHostName, Data: []byte("darkstar")}
 	bootFileOpt1 := &OptionGeneric{OptionCode: OptionBootfileName, Data: []byte("boot.img")}
@@ -363,6 +361,23 @@ func TestAddOption(t *testing.T) {
 	require.Equal(t, options[3].Code(), OptionEnd)
 }
 
+func TestUpdateOption(t *testing.T) {
+	d, err := New()
+	require.NoError(t, err)
+	require.Equal(t, 1, len(d.options))
+	require.Equal(t, OptionEnd, d.options[0].Code())
+	// test that it will add the option since it's missing
+	d.UpdateOption(&OptDomainName{DomainName: "slackware.it"})
+	require.Equal(t, 2, len(d.options))
+	require.Equal(t, OptionDomainName, d.options[0].Code())
+	require.Equal(t, OptionEnd, d.options[1].Code())
+	// test that it won't add another option of the same type
+	d.UpdateOption(&OptDomainName{DomainName: "slackware.it"})
+	require.Equal(t, 2, len(d.options))
+	require.Equal(t, OptionDomainName, d.options[0].Code())
+	require.Equal(t, OptionEnd, d.options[1].Code())
+}
+
 func TestStrippedOptions(t *testing.T) {
 	// Normal set of options that terminate with OptionEnd.
 	d, err := New()