dhcpv4: nicer API for option parsing.

From:
  r := d.GetOneOption(OptionRouter).(*OptRouter).Routers
  d.UpdateOption(&OptRouter{Routers: []net.IP{net.IP{192, 168, 0, 1}}})

To:
  r := GetRouter(d.Options)
  d.UpdateOption(OptRouter(net.IP{192, 168, 0, 1}, ...))

1 files changed, 0 insertions, 46 deletions

diff --git a/dhcpv4/bsdp/bsdp_option_selected_boot_image_id_test.go b/dhcpv4/bsdp/bsdp_option_selected_boot_image_id_test.go
deleted file mode 100644
index e187fc7..0000000
--- a/dhcpv4/bsdp/bsdp_option_selected_boot_image_id_test.go
+++ /dev/null
@@ -1,46 +0,0 @@
-package bsdp
-
-import (
-	"testing"
-
-	"github.com/stretchr/testify/require"
-	"github.com/u-root/u-root/pkg/uio"
-)
-
-func TestOptSelectedBootImageIDInterfaceMethods(t *testing.T) {
-	b := BootImageID{IsInstall: true, ImageType: BootImageTypeMacOSX, Index: 1001}
-	o := OptSelectedBootImageID{b}
-	require.Equal(t, OptionSelectedBootImageID, o.Code(), "Code")
-	require.Equal(t, uio.ToBigEndian(b), o.ToBytes(), "ToBytes")
-}
-
-func TestParseOptSelectedBootImageID(t *testing.T) {
-	b := BootImageID{IsInstall: true, ImageType: BootImageTypeMacOSX, Index: 1001}
-	o, err := ParseOptSelectedBootImageID(uio.ToBigEndian(b))
-	require.NoError(t, err)
-	require.Equal(t, &OptSelectedBootImageID{b}, o)
-
-	// Short byte stream
-	data := []byte{}
-	_, err = ParseOptSelectedBootImageID(data)
-	require.Error(t, err, "should get error from short byte stream")
-
-	// Bad length
-	data = []byte{1, 0, 0, 0, 0}
-	_, err = ParseOptSelectedBootImageID(data)
-	require.Error(t, err, "should get error from bad length")
-}
-
-func TestOptSelectedBootImageIDString(t *testing.T) {
-	b := BootImageID{IsInstall: true, ImageType: BootImageTypeMacOSX, Index: 1001}
-	o := OptSelectedBootImageID{b}
-	require.Equal(t, "BSDP Selected Boot Image ID -> [1001] installable macOS image", o.String())
-
-	b = BootImageID{IsInstall: false, ImageType: BootImageTypeMacOS9, Index: 1001}
-	o = OptSelectedBootImageID{b}
-	require.Equal(t, "BSDP Selected Boot Image ID -> [1001] uninstallable macOS 9 image", o.String())
-
-	b = BootImageID{IsInstall: false, ImageType: BootImageType(99), Index: 1001}
-	o = OptSelectedBootImageID{b}
-	require.Equal(t, "BSDP Selected Boot Image ID -> [1001] uninstallable unknown image", o.String())
-}