1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
|
// Copyright 2019 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include <errno.h>
#include <poll.h>
#include <signal.h>
#include <stdio.h>
#include <string.h>
#include <sys/signalfd.h>
#include <unistd.h>
#include <functional>
#include <vector>
#include "gtest/gtest.h"
#include "absl/synchronization/mutex.h"
#include "test/util/file_descriptor.h"
#include "test/util/posix_error.h"
#include "test/util/signal_util.h"
#include "test/util/test_util.h"
#include "test/util/thread_util.h"
using ::testing::KilledBySignal;
namespace gvisor {
namespace testing {
namespace {
constexpr int kSigno = SIGUSR1;
constexpr int kSignoAlt = SIGUSR2;
// Returns a new signalfd.
inline PosixErrorOr<FileDescriptor> NewSignalFD(sigset_t* mask, int flags = 0) {
int fd = signalfd(-1, mask, flags);
MaybeSave();
if (fd < 0) {
return PosixError(errno, "signalfd");
}
return FileDescriptor(fd);
}
TEST(Signalfd, Basic) {
// Create the signalfd.
sigset_t mask;
sigemptyset(&mask);
sigaddset(&mask, kSigno);
FileDescriptor fd = ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, 0));
// Deliver the blocked signal.
const auto scoped_sigmask =
ASSERT_NO_ERRNO_AND_VALUE(ScopedSignalMask(SIG_BLOCK, kSigno));
ASSERT_THAT(tgkill(getpid(), gettid(), kSigno), SyscallSucceeds());
// We should now read the signal.
struct signalfd_siginfo rbuf;
ASSERT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallSucceedsWithValue(sizeof(rbuf)));
EXPECT_EQ(rbuf.ssi_signo, kSigno);
}
TEST(Signalfd, MaskWorks) {
// Create two signalfds with different masks.
sigset_t mask1, mask2;
sigemptyset(&mask1);
sigemptyset(&mask2);
sigaddset(&mask1, kSigno);
sigaddset(&mask2, kSignoAlt);
FileDescriptor fd1 = ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask1, 0));
FileDescriptor fd2 = ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask2, 0));
// Deliver the two signals.
const auto scoped_sigmask1 =
ASSERT_NO_ERRNO_AND_VALUE(ScopedSignalMask(SIG_BLOCK, kSigno));
const auto scoped_sigmask2 =
ASSERT_NO_ERRNO_AND_VALUE(ScopedSignalMask(SIG_BLOCK, kSignoAlt));
ASSERT_THAT(tgkill(getpid(), gettid(), kSigno), SyscallSucceeds());
ASSERT_THAT(tgkill(getpid(), gettid(), kSignoAlt), SyscallSucceeds());
// We should see the signals on the appropriate signalfds.
//
// We read in the opposite order as the signals deliver above, to ensure that
// we don't happen to read the correct signal from the correct signalfd.
struct signalfd_siginfo rbuf1, rbuf2;
ASSERT_THAT(read(fd2.get(), &rbuf2, sizeof(rbuf2)),
SyscallSucceedsWithValue(sizeof(rbuf2)));
EXPECT_EQ(rbuf2.ssi_signo, kSignoAlt);
ASSERT_THAT(read(fd1.get(), &rbuf1, sizeof(rbuf1)),
SyscallSucceedsWithValue(sizeof(rbuf1)));
EXPECT_EQ(rbuf1.ssi_signo, kSigno);
}
TEST(Signalfd, Cloexec) {
// Exec tests confirm that O_CLOEXEC has the intended effect. We just create a
// signalfd with the appropriate flag here and assert that the FD has it set.
sigset_t mask;
sigemptyset(&mask);
FileDescriptor fd =
ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, SFD_CLOEXEC));
EXPECT_THAT(fcntl(fd.get(), F_GETFD), SyscallSucceedsWithValue(FD_CLOEXEC));
}
TEST(Signalfd, Blocking) {
// Create the signalfd in blocking mode.
sigset_t mask;
sigemptyset(&mask);
sigaddset(&mask, kSigno);
FileDescriptor fd = ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, 0));
// Shared tid variable.
absl::Mutex mu;
bool has_tid;
pid_t tid;
// Start a thread reading.
ScopedThread t([&] {
// Copy the tid and notify the caller.
{
absl::MutexLock ml(&mu);
tid = gettid();
has_tid = true;
}
// Read the signal from the signalfd.
struct signalfd_siginfo rbuf;
ASSERT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallSucceedsWithValue(sizeof(rbuf)));
EXPECT_EQ(rbuf.ssi_signo, kSigno);
});
// Wait until blocked.
absl::MutexLock ml(&mu);
mu.Await(absl::Condition(&has_tid));
// Deliver the signal to either the waiting thread, or
// to this thread. N.B. this is a bug in the core gVisor
// behavior for signalfd, and needs to be fixed.
//
// See gvisor.dev/issue/139.
if (IsRunningOnGvisor()) {
ASSERT_THAT(tgkill(getpid(), gettid(), kSigno), SyscallSucceeds());
} else {
ASSERT_THAT(tgkill(getpid(), tid, kSigno), SyscallSucceeds());
}
// Ensure that it was received.
t.Join();
}
TEST(Signalfd, ThreadGroup) {
// Create the signalfd in blocking mode.
sigset_t mask;
sigemptyset(&mask);
sigaddset(&mask, kSigno);
FileDescriptor fd = ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, 0));
// Shared variable.
absl::Mutex mu;
bool first = false;
bool second = false;
// Start a thread reading.
ScopedThread t([&] {
// Read the signal from the signalfd.
struct signalfd_siginfo rbuf;
ASSERT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallSucceedsWithValue(sizeof(rbuf)));
EXPECT_EQ(rbuf.ssi_signo, kSigno);
// Wait for the other thread.
absl::MutexLock ml(&mu);
first = true;
mu.Await(absl::Condition(&second));
});
// Deliver the signal to the threadgroup.
ASSERT_THAT(kill(getpid(), kSigno), SyscallSucceeds());
// Wait for the first thread to process.
{
absl::MutexLock ml(&mu);
mu.Await(absl::Condition(&first));
}
// Deliver to the thread group again (other thread still exists).
ASSERT_THAT(kill(getpid(), kSigno), SyscallSucceeds());
// Ensure that we can also receive it.
struct signalfd_siginfo rbuf;
ASSERT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallSucceedsWithValue(sizeof(rbuf)));
EXPECT_EQ(rbuf.ssi_signo, kSigno);
// Mark the test as done.
{
absl::MutexLock ml(&mu);
second = true;
}
// The other thread should be joinable.
t.Join();
}
TEST(Signalfd, Nonblock) {
// Create the signalfd in non-blocking mode.
sigset_t mask;
sigemptyset(&mask);
sigaddset(&mask, kSigno);
FileDescriptor fd =
ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, SFD_NONBLOCK));
// We should return if we attempt to read.
struct signalfd_siginfo rbuf;
ASSERT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallFailsWithErrno(EWOULDBLOCK));
// Block and deliver the signal.
const auto scoped_sigmask =
ASSERT_NO_ERRNO_AND_VALUE(ScopedSignalMask(SIG_BLOCK, kSigno));
ASSERT_THAT(tgkill(getpid(), gettid(), kSigno), SyscallSucceeds());
// Ensure that a read actually works.
ASSERT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallSucceedsWithValue(sizeof(rbuf)));
EXPECT_EQ(rbuf.ssi_signo, kSigno);
// Should block again.
EXPECT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallFailsWithErrno(EWOULDBLOCK));
}
TEST(Signalfd, SetMask) {
// Create the signalfd matching nothing.
sigset_t mask;
sigemptyset(&mask);
FileDescriptor fd =
ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, SFD_NONBLOCK));
// Block and deliver a signal.
const auto scoped_sigmask =
ASSERT_NO_ERRNO_AND_VALUE(ScopedSignalMask(SIG_BLOCK, kSigno));
ASSERT_THAT(tgkill(getpid(), gettid(), kSigno), SyscallSucceeds());
// We should have nothing.
struct signalfd_siginfo rbuf;
ASSERT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallFailsWithErrno(EWOULDBLOCK));
// Change the signal mask.
sigaddset(&mask, kSigno);
ASSERT_THAT(signalfd(fd.get(), &mask, 0), SyscallSucceeds());
// We should now have the signal.
ASSERT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallSucceedsWithValue(sizeof(rbuf)));
EXPECT_EQ(rbuf.ssi_signo, kSigno);
}
TEST(Signalfd, Poll) {
// Create the signalfd.
sigset_t mask;
sigemptyset(&mask);
sigaddset(&mask, kSigno);
FileDescriptor fd = ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, 0));
// Block the signal, and start a thread to deliver it.
const auto scoped_sigmask =
ASSERT_NO_ERRNO_AND_VALUE(ScopedSignalMask(SIG_BLOCK, kSigno));
pid_t orig_tid = gettid();
ScopedThread t([&] {
absl::SleepFor(absl::Seconds(5));
ASSERT_THAT(tgkill(getpid(), orig_tid, kSigno), SyscallSucceeds());
});
// Start polling for the signal. We expect that it is not available at the
// outset, but then becomes available when the signal is sent. We give a
// timeout of 10000ms (or the delay above + 5 seconds of additional grace
// time).
struct pollfd poll_fd = {fd.get(), POLLIN, 0};
EXPECT_THAT(RetryEINTR(poll)(&poll_fd, 1, 10000),
SyscallSucceedsWithValue(1));
// Actually read the signal to prevent delivery.
struct signalfd_siginfo rbuf;
EXPECT_THAT(read(fd.get(), &rbuf, sizeof(rbuf)),
SyscallSucceedsWithValue(sizeof(rbuf)));
}
TEST(Signalfd, KillStillKills) {
sigset_t mask;
sigemptyset(&mask);
sigaddset(&mask, SIGKILL);
FileDescriptor fd =
ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, SFD_CLOEXEC));
// Just because there is a signalfd, we shouldn't see any change in behavior
// for unblockable signals. It's easier to test this with SIGKILL.
const auto scoped_sigmask =
ASSERT_NO_ERRNO_AND_VALUE(ScopedSignalMask(SIG_BLOCK, SIGKILL));
EXPECT_EXIT(tgkill(getpid(), gettid(), SIGKILL), KilledBySignal(SIGKILL), "");
}
TEST(Signalfd, Ppoll) {
sigset_t mask;
sigemptyset(&mask);
sigaddset(&mask, SIGKILL);
FileDescriptor fd =
ASSERT_NO_ERRNO_AND_VALUE(NewSignalFD(&mask, SFD_CLOEXEC));
// Ensure that the given ppoll blocks.
struct pollfd pfd = {};
pfd.fd = fd.get();
pfd.events = POLLIN;
struct timespec timeout = {};
timeout.tv_sec = 1;
EXPECT_THAT(RetryEINTR(ppoll)(&pfd, 1, &timeout, &mask),
SyscallSucceedsWithValue(0));
}
} // namespace
} // namespace testing
} // namespace gvisor
int main(int argc, char** argv) {
// These tests depend on delivering signals. Block them up front so that all
// other threads created by TestInit will also have them blocked, and they
// will not interface with the rest of the test.
sigset_t set;
sigemptyset(&set);
sigaddset(&set, gvisor::testing::kSigno);
sigaddset(&set, gvisor::testing::kSignoAlt);
TEST_PCHECK(sigprocmask(SIG_BLOCK, &set, nullptr) == 0);
gvisor::testing::TestInit(&argc, &argv);
return RUN_ALL_TESTS();
}
|