diff options
author | Jamie Liu <jamieliu@google.com> | 2019-01-25 13:34:19 -0800 |
---|---|---|
committer | Shentubot <shentubot@google.com> | 2019-01-25 13:35:32 -0800 |
commit | 876b241fac98e1e23f25ea4ccdca7768e0a7877f (patch) | |
tree | 33e36e7889e58f2bb0ef678bf753f95422b0182d /test/syscalls/linux/socket_unix_unbound_dgram.cc | |
parent | cc995207531965b70bc1b812a70b91f242a92086 (diff) |
Remove O_CLOEXEC from socket test configurations where irrelevant.
The implementation of O_CLOEXEC is orthogonal to every property tested
by these tests; removing it significantly reduces the number of
redundant tests we run.
Also remove no-op calls to VecCat (calls with a single argument).
PiperOrigin-RevId: 230959537
Change-Id: I83fe7db24e481ef67ca1f1992228af423f640b5c
Diffstat (limited to 'test/syscalls/linux/socket_unix_unbound_dgram.cc')
-rw-r--r-- | test/syscalls/linux/socket_unix_unbound_dgram.cc | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/test/syscalls/linux/socket_unix_unbound_dgram.cc b/test/syscalls/linux/socket_unix_unbound_dgram.cc index a01b7f644..155d8974a 100644 --- a/test/syscalls/linux/socket_unix_unbound_dgram.cc +++ b/test/syscalls/linux/socket_unix_unbound_dgram.cc @@ -145,16 +145,14 @@ TEST_P(UnboundDgramUnixSocketPairTest, SendtoWithoutConnect) { INSTANTIATE_TEST_CASE_P( AllUnixDomainSockets, UnboundDgramUnixSocketPairTest, ::testing::ValuesIn(VecCat<SocketPairKind>( - ApplyVec<SocketPairKind>( - FilesystemUnboundUnixDomainSocketPair, - AllBitwiseCombinations(List<int>{SOCK_DGRAM}, - List<int>{0, SOCK_NONBLOCK}, - List<int>{0, SOCK_CLOEXEC})), + ApplyVec<SocketPairKind>(FilesystemUnboundUnixDomainSocketPair, + AllBitwiseCombinations(List<int>{SOCK_DGRAM}, + List<int>{ + 0, SOCK_NONBLOCK})), ApplyVec<SocketPairKind>( AbstractUnboundUnixDomainSocketPair, AllBitwiseCombinations(List<int>{SOCK_DGRAM}, - List<int>{0, SOCK_NONBLOCK}, - List<int>{0, SOCK_CLOEXEC}))))); + List<int>{0, SOCK_NONBLOCK}))))); } // namespace |