diff options
| author | Bhasker Hariharan <bhaskerh@google.com> | 2020-02-25 11:18:28 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-02-25 11:19:34 -0800 |
| commit | d7b73792515d1ac34c8d8c41ef5de379f22f002b (patch) | |
| tree | fc7d8f1d756118913251366e32b6aa4d56d440c6 /pkg/tcpip/transport/tcp/tcp_test.go | |
| parent | 4d7db46123f020df77cea5c00df4114b7b073845 (diff) | |
Deflake TestCurrentConnectedIncrement.
TestCurrentConnectedIncrement fails consistently under gotsan due to the sleep
to check metrics is exactly the same as the TIME-WAIT duration. Under gotsan
things can be slow enough that the increment test is done before the protocol
goroutine is run after the TIME-WAIT timer expires and does its cleanup.
Increasing the sleep from 1s to 1.2s makes the test pass consistently.
PiperOrigin-RevId: 297160181
Diffstat (limited to 'pkg/tcpip/transport/tcp/tcp_test.go')
| -rw-r--r-- | pkg/tcpip/transport/tcp/tcp_test.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/pkg/tcpip/transport/tcp/tcp_test.go b/pkg/tcpip/transport/tcp/tcp_test.go index cc118c993..5b2b16afa 100644 --- a/pkg/tcpip/transport/tcp/tcp_test.go +++ b/pkg/tcpip/transport/tcp/tcp_test.go @@ -543,8 +543,9 @@ func TestCurrentConnectedIncrement(t *testing.T) { ), ) - // Wait for the TIME-WAIT state to transition to CLOSED. - time.Sleep(1 * time.Second) + // Wait for a little more than the TIME-WAIT duration for the socket to + // transition to CLOSED state. + time.Sleep(1200 * time.Millisecond) if got := c.Stack().Stats().TCP.CurrentEstablished.Value(); got != 0 { t.Errorf("got stats.TCP.CurrentEstablished.Value() = %v, want = 0", got) |