summaryrefslogtreecommitdiffhomepage
path: root/pkg/tcpip/transport/ping/protocol.go
diff options
context:
space:
mode:
authorGoogler <noreply@google.com>2018-08-31 15:47:49 -0700
committerShentubot <shentubot@google.com>2018-08-31 15:48:50 -0700
commitf0d88176549f097fadd3d547827aed3b951ddc92 (patch)
tree5b085af5ac189e19e2e186e10cccf16b7ab837e7 /pkg/tcpip/transport/ping/protocol.go
parentf8ccfbbed4875e65c78c849cd46afa882ba68ee3 (diff)
Automated rollback of changelist 211103930
PiperOrigin-RevId: 211156845 Change-Id: Ie28011d7eb5f45f3a0158dbee2a68c5edf22f6e0
Diffstat (limited to 'pkg/tcpip/transport/ping/protocol.go')
-rw-r--r--pkg/tcpip/transport/ping/protocol.go16
1 files changed, 4 insertions, 12 deletions
diff --git a/pkg/tcpip/transport/ping/protocol.go b/pkg/tcpip/transport/ping/protocol.go
index b885f3627..8a8192064 100644
--- a/pkg/tcpip/transport/ping/protocol.go
+++ b/pkg/tcpip/transport/ping/protocol.go
@@ -71,7 +71,7 @@ func (p *protocol) NewEndpoint(stack *stack.Stack, netProto tcpip.NetworkProtoco
if netProto != p.netProto() {
return nil, tcpip.ErrUnknownProtocol
}
- return newEndpoint(stack, netProto, p.number, waiterQueue), nil
+ return newEndpoint(stack, netProto, waiterQueue), nil
}
// MinimumPacketSize returns the minimum valid ping packet size.
@@ -87,14 +87,8 @@ func (p *protocol) MinimumPacketSize() int {
// ParsePorts returns the source and destination ports stored in the given ping
// packet.
-func (p *protocol) ParsePorts(v buffer.View) (src, dst uint16, err *tcpip.Error) {
- switch p.number {
- case ProtocolNumber4:
- return 0, binary.BigEndian.Uint16(v[header.ICMPv4MinimumSize:]), nil
- case ProtocolNumber6:
- return 0, binary.BigEndian.Uint16(v[header.ICMPv6MinimumSize:]), nil
- }
- panic(fmt.Sprint("unknown protocol number: ", p.number))
+func (*protocol) ParsePorts(v buffer.View) (src, dst uint16, err *tcpip.Error) {
+ return 0, binary.BigEndian.Uint16(v[header.ICMPv4MinimumSize:]), nil
}
// HandleUnknownDestinationPacket handles packets targeted at this protocol but
@@ -118,7 +112,5 @@ func init() {
return &protocol{ProtocolNumber4}
})
- stack.RegisterTransportProtocolFactory(ProtocolName6, func() stack.TransportProtocol {
- return &protocol{ProtocolNumber6}
- })
+ // TODO: Support IPv6.
}