diff options
| author | Fabricio Voznika <fvoznika@google.com> | 2018-11-20 22:55:41 -0800 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2018-11-20 22:56:51 -0800 |
| commit | eaac94d91c28b745c51c33dd352ed9bfdd671b8c (patch) | |
| tree | e552c91970be74c3a315bb6aa5eea157cb153890 /pkg/sentry/platform/ptrace/subprocess_linux.go | |
| parent | 5236b78242677612ac71b19cee85b3bf4cca4008 (diff) | |
Use RET_KILL_PROCESS if available in kernel
RET_KILL_THREAD doesn't work well for Go because it will
kill only the offending thread and leave the process hanging.
RET_TRAP can be masked out and it's not guaranteed to kill
the process. RET_KILL_PROCESS is available since 4.14.
For older kernel, continue to use RET_TRAP as this is the
best option (likely to kill process, easy to debug).
PiperOrigin-RevId: 222357867
Change-Id: Icc1d7d731274b16c2125b7a1ba4f7883fbdb2cbd
Diffstat (limited to 'pkg/sentry/platform/ptrace/subprocess_linux.go')
| -rw-r--r-- | pkg/sentry/platform/ptrace/subprocess_linux.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/sentry/platform/ptrace/subprocess_linux.go b/pkg/sentry/platform/ptrace/subprocess_linux.go index 885ba4b2e..25b8e8cb7 100644 --- a/pkg/sentry/platform/ptrace/subprocess_linux.go +++ b/pkg/sentry/platform/ptrace/subprocess_linux.go @@ -115,7 +115,7 @@ func createStub() (*thread, error) { var defaultAction uint32 if probeSeccomp() { log.Infof("Latest seccomp behavior found (kernel >= 4.8 likely)") - defaultAction = uint32(linux.SECCOMP_RET_KILL) + defaultAction = uint32(linux.SECCOMP_RET_KILL_THREAD) } else { // We must rely on SYSEMU behavior; tracing with SYSEMU is broken. log.Infof("Legacy seccomp behavior found (kernel < 4.8 likely)") |