summaryrefslogtreecommitdiffhomepage
path: root/pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go
diff options
context:
space:
mode:
authorJamie Liu <jamieliu@google.com>2019-12-30 11:35:06 -0800
committergVisor bot <gvisor-bot@google.com>2019-12-30 11:36:41 -0800
commit1f384ac42b9ee8b52000dc2bff79d975853519ed (patch)
tree64d0bed36c4b8fa3005b13463d2995fc0a2eeb37 /pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go
parent796f53c0befc21570b185811e26b74e71950dfc3 (diff)
Add VFS2 support for device special files.
- Add FileDescriptionOptions.UseDentryMetadata, which reduces the amount of boilerplate needed for device FDs and the like between filesystems. - Switch back to having FileDescription.Init() take references on the Mount and Dentry; otherwise managing refcounts around failed calls to OpenDeviceSpecialFile() / Device.Open() is tricky. PiperOrigin-RevId: 287575574
Diffstat (limited to 'pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go')
-rw-r--r--pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go2
1 files changed, 0 insertions, 2 deletions
diff --git a/pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go b/pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go
index c5fe65722..606ca692d 100644
--- a/pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go
+++ b/pkg/sentry/fsimpl/kernfs/dynamic_bytes_file.go
@@ -81,8 +81,6 @@ type DynamicBytesFD struct {
// Init initializes a DynamicBytesFD.
func (fd *DynamicBytesFD) Init(m *vfs.Mount, d *vfs.Dentry, data vfs.DynamicBytesSource, flags uint32) {
- m.IncRef() // DecRef in vfs.FileDescription.vd.DecRef on final ref.
- d.IncRef() // DecRef in vfs.FileDescription.vd.DecRef on final ref.
fd.inode = d.Impl().(*Dentry).inode
fd.SetDataSource(data)
fd.vfsfd.Init(fd, flags, m, d, &vfs.FileDescriptionOptions{})