diff options
| author | Nicolas Lacasse <nlacasse@google.com> | 2018-10-10 14:33:59 -0700 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2018-10-10 14:35:03 -0700 |
| commit | 1939cd020f19a17707eb5e597e010fea8ab35de5 (patch) | |
| tree | 939f5b55f4e3a9c053e0830dff665b88764fcf3c /pkg/sentry/fs/dirent_cache.go | |
| parent | 8388a505e735045f31c6f7180711ef57148dc517 (diff) | |
runsc: Pass controlling TTY by FD in the *new* process, not current process.
When setting Cmd.SysProcAttr.Ctty, the FD must be the FD of the controlling TTY
in the new process, not the current process. The ioctl call is made after
duping all FDs in Cmd.ExtraFiles, which may stomp on the old TTY FD.
This fixes the "bad address" flakes in runsc/container:container_test, although
some other flakes remain.
PiperOrigin-RevId: 216594394
Change-Id: Idfd1677abb866aa82ad7e8be776f0c9087256862
Diffstat (limited to 'pkg/sentry/fs/dirent_cache.go')
0 files changed, 0 insertions, 0 deletions