diff options
author | Adin Scannell <ascannell@google.com> | 2019-08-22 14:33:16 -0700 |
---|---|---|
committer | gVisor bot <gvisor-bot@google.com> | 2019-08-22 14:34:33 -0700 |
commit | 761e4bf2fe520dae1120341b09c26be1577a2adb (patch) | |
tree | 1b05f88200ba0293e6009d1d573869f645963f48 | |
parent | 0e82f9f3fb76600e4c7987f95a65b140860ee845 (diff) |
Ensure yield-equivalent with an already-expired timeout.
PiperOrigin-RevId: 264920977
-rw-r--r-- | pkg/sentry/kernel/task_block.go | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/pkg/sentry/kernel/task_block.go b/pkg/sentry/kernel/task_block.go index 2a2e6f662..dd69939f9 100644 --- a/pkg/sentry/kernel/task_block.go +++ b/pkg/sentry/kernel/task_block.go @@ -15,6 +15,7 @@ package kernel import ( + "runtime" "time" ktime "gvisor.dev/gvisor/pkg/sentry/kernel/time" @@ -121,6 +122,17 @@ func (t *Task) block(C <-chan struct{}, timerChan <-chan struct{}) error { // Deactive our address space, we don't need it. interrupt := t.SleepStart() + // If the request is not completed, but the timer has already expired, + // then ensure that we run through a scheduler cycle. This is because + // we may see applications relying on timer slack to yield the thread. + // For example, they may attempt to sleep for some number of nanoseconds, + // and expect that this will actually yield the CPU and sleep for at + // least microseconds, e.g.: + // https://github.com/LMAX-Exchange/disruptor/commit/6ca210f2bcd23f703c479804d583718e16f43c07 + if len(timerChan) > 0 { + runtime.Gosched() + } + select { case <-C: t.SleepFinish(true) |