summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorTamir Duberstein <tamird@google.com>2021-04-09 03:41:33 -0700
committergVisor bot <gvisor-bot@google.com>2021-04-09 03:43:23 -0700
commit1fe5dd8c68ef75facb0c6075a2324d816f4d2c50 (patch)
tree1b5f70b34462d39a191628eaaf9fb085d3070429
parentedf30a9bc5a645a7e03fca81f3e5852214588021 (diff)
Propagate SYN handling error
Both callers of this function still drop this error on the floor, but progress is progress. Updates #4690. PiperOrigin-RevId: 367604788
-rw-r--r--pkg/tcpip/transport/tcp/accept.go3
1 files changed, 1 insertions, 2 deletions
diff --git a/pkg/tcpip/transport/tcp/accept.go b/pkg/tcpip/transport/tcp/accept.go
index 7372ebc08..f020ff8fa 100644
--- a/pkg/tcpip/transport/tcp/accept.go
+++ b/pkg/tcpip/transport/tcp/accept.go
@@ -543,8 +543,7 @@ func (e *endpoint) handleListenSegment(ctx *listenContext, s *segment) tcpip.Err
if !e.acceptQueueIsFull() {
s.incRef()
atomic.AddInt32(&e.synRcvdCount, 1)
- _ = e.handleSynSegment(ctx, s, &opts)
- return nil
+ return e.handleSynSegment(ctx, s, &opts)
}
e.stack.Stats().TCP.ListenOverflowSynDrop.Increment()
e.stats.ReceiveErrors.ListenOverflowSynDrop.Increment()