From 1fe5dd8c68ef75facb0c6075a2324d816f4d2c50 Mon Sep 17 00:00:00 2001 From: Tamir Duberstein Date: Fri, 9 Apr 2021 03:41:33 -0700 Subject: Propagate SYN handling error Both callers of this function still drop this error on the floor, but progress is progress. Updates #4690. PiperOrigin-RevId: 367604788 --- pkg/tcpip/transport/tcp/accept.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/tcpip/transport/tcp/accept.go b/pkg/tcpip/transport/tcp/accept.go index 7372ebc08..f020ff8fa 100644 --- a/pkg/tcpip/transport/tcp/accept.go +++ b/pkg/tcpip/transport/tcp/accept.go @@ -543,8 +543,7 @@ func (e *endpoint) handleListenSegment(ctx *listenContext, s *segment) tcpip.Err if !e.acceptQueueIsFull() { s.incRef() atomic.AddInt32(&e.synRcvdCount, 1) - _ = e.handleSynSegment(ctx, s, &opts) - return nil + return e.handleSynSegment(ctx, s, &opts) } e.stack.Stats().TCP.ListenOverflowSynDrop.Increment() e.stats.ReceiveErrors.ListenOverflowSynDrop.Increment() -- cgit v1.2.3