summaryrefslogtreecommitdiffhomepage
path: root/test
diff options
context:
space:
mode:
authorIWASE Yusuke <iwase.yusuke0@gmail.com>2018-05-16 15:49:53 +0900
committerFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>2018-05-23 13:00:33 +0900
commit34f74cd314c512ee028983a321d1012f63adb26d (patch)
treed272423a59336b8c88e725fc68624ceba7242b61 /test
parent2c5f27f7cf5ea564ff13f804c4a7f8cf5cde4b5c (diff)
bgp_zebra_nht_test: Improve pylint result
Also removes a debug print. Signed-off-by: IWASE Yusuke <iwase.yusuke0@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/scenario_test/bgp_zebra_nht_test.py15
1 files changed, 8 insertions, 7 deletions
diff --git a/test/scenario_test/bgp_zebra_nht_test.py b/test/scenario_test/bgp_zebra_nht_test.py
index feadbded..b7937ccd 100644
--- a/test/scenario_test/bgp_zebra_nht_test.py
+++ b/test/scenario_test/bgp_zebra_nht_test.py
@@ -80,9 +80,6 @@ class ZebraNHTTest(unittest.TestCase):
def setUpClass(cls):
gobgp_ctn_image_name = parser_option.gobgp_image
base.TEST_PREFIX = parser_option.test_prefix
-
- local("echo 'start %s'" % cls.__name__, capture=True)
-
cls.r1 = GoBGPContainer(
name='r1', asn=65000, router_id='192.168.0.1',
ctn_image_name=gobgp_ctn_image_name,
@@ -132,16 +129,20 @@ class ZebraNHTTest(unittest.TestCase):
time.sleep(wait_time)
cls.br_r1_r2 = Bridge(name='br_r1_r2', subnet='192.168.12.0/24')
- [cls.br_r1_r2.addif(ctn) for ctn in (cls.r1, cls.r2)]
+ for ctn in (cls.r1, cls.r2):
+ cls.br_r1_r2.addif(ctn)
cls.br_r2_r3 = Bridge(name='br_r2_r3', subnet='192.168.23.0/24')
- [cls.br_r2_r3.addif(ctn) for ctn in (cls.r2, cls.r3)]
+ for ctn in (cls.r2, cls.r3):
+ cls.br_r2_r3.addif(ctn)
cls.br_r2_r4 = Bridge(name='br_r2_r4', subnet='192.168.24.0/24')
- [cls.br_r2_r4.addif(ctn) for ctn in (cls.r2, cls.r4)]
+ for ctn in (cls.r2, cls.r4):
+ cls.br_r2_r4.addif(ctn)
cls.br_r3_r4 = Bridge(name='br_r3_r4', subnet='192.168.34.0/24')
- [cls.br_r3_r4.addif(ctn) for ctn in (cls.r3, cls.r4)]
+ for ctn in (cls.r3, cls.r4):
+ cls.br_r3_r4.addif(ctn)
def test_01_BGP_neighbor_established(self):
# Test to start BGP connection up between r1-r2.