table: fix to compare new best path with old best path

The current code uses Path.Equal(), which just check out if pathes are
idential. However, it doesn't work for two cloned pathes of a path
(soft update in case).

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

1 files changed, 17 insertions, 1 deletions

diff --git a/table/path.go b/table/path.go
index eefc2780..77b811d1 100644
--- a/table/path.go
+++ b/table/path.go
@@ -835,5 +835,21 @@ func (path *Path) GetOrigin() (uint8, error) {
 }
 
 func (lhs *Path) Equal(rhs *Path) bool {
-	return lhs == rhs
+	if rhs == nil {
+		return false
+	}
+
+	if lhs.GetSource() != rhs.GetSource() {
+		return false
+	}
+
+	pattrs := func(arg []bgp.PathAttributeInterface) []byte {
+		ret := make([]byte, 0)
+		for _, a := range arg {
+			aa, _ := a.Serialize()
+			ret = append(ret, aa...)
+		}
+		return ret
+	}
+	return bytes.Equal(pattrs(lhs.GetPathAttrs()), pattrs(rhs.GetPathAttrs()))
 }