server: improve ListPath's performance

send large data rather than sending small repeatedly.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>

1 files changed, 10 insertions, 3 deletions

diff --git a/pkg/server/grpc_server.go b/pkg/server/grpc_server.go
index 725ab77a..3c7527b2 100644
--- a/pkg/server/grpc_server.go
+++ b/pkg/server/grpc_server.go
@@ -171,12 +171,19 @@ func getValidation(v []*table.Validation, i int) *table.Validation {
 func (s *server) ListPath(r *api.ListPathRequest, stream api.GobgpApi_ListPathServer) error {
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
-	fn := func(d *api.Destination) {
+	l := make([]*api.Destination, 0)
+	err := s.bgpServer.ListPath(ctx, r, func(d *api.Destination) {
+		l = append(l, d)
+	})
+	if err != nil {
+		return err
+	}
+	for _, d := range l {
 		if err := stream.Send(&api.ListPathResponse{Destination: d}); err != nil {
-			cancel()
+			break
 		}
 	}
-	return s.bgpServer.ListPath(ctx, r, fn)
+	return err
 }
 
 func (s *server) MonitorTable(arg *api.MonitorTableRequest, stream api.GobgpApi_MonitorTableServer) error {