summaryrefslogtreecommitdiffhomepage
path: root/shell/cmdedit.c
diff options
context:
space:
mode:
authorRobert Griebl <griebl@gmx.de>2002-07-19 00:05:54 +0000
committerRobert Griebl <griebl@gmx.de>2002-07-19 00:05:54 +0000
commitd378c3149c6c24e7788f04a6d20ba360f3ea407e (patch)
tree945ff88bbbde5a32c2b3342b22d801be90ea40f2 /shell/cmdedit.c
parent88947dd05e28a3b793b16dfd6db1b5414ca99017 (diff)
Applied vodz' patches #49 and #50 (with a small correction in runshell.c)
#49: I found one memory overflow and memory leak in "ln" applet. Last patch reduced also 54 bytes. ;) #50: I found bug in loginutils/Makefile.in. New patch have also new function to libbb and aplied this to applets and other cosmetic changes.
Diffstat (limited to 'shell/cmdedit.c')
-rw-r--r--shell/cmdedit.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/shell/cmdedit.c b/shell/cmdedit.c
index c5f2e9da2..5cbc81131 100644
--- a/shell/cmdedit.c
+++ b/shell/cmdedit.c
@@ -611,8 +611,7 @@ static char **username_tab_completion(char *ud, int *num_matches)
/* Null usernames should result in all users as possible completions. */
if ( /*!userlen || */ !strncmp(ud, entry->pw_name, userlen)) {
- temp = xmalloc(3 + strlen(entry->pw_name));
- sprintf(temp, "~%s/", entry->pw_name);
+ bb_asprintf(&temp, "~%s/", entry->pw_name);
matches = xrealloc(matches, (nm + 1) * sizeof(char *));
matches[nm++] = temp;