diff options
| author | Denis Vlasenko <vda.linux@googlemail.com> | 2008-07-01 10:40:41 +0000 |
|---|---|---|
| committer | Denis Vlasenko <vda.linux@googlemail.com> | 2008-07-01 10:40:41 +0000 |
| commit | 3da5572bfa81a63ce66e41b99e9801c47a05bbbf (patch) | |
| tree | 91e495d81283309948b9f459bbd65c17682431fa /miscutils | |
| parent | 148f67af9dac56db4703fb40677630ef559edb57 (diff) | |
*: introduce and use xvfork()
function old new delta
time_main 1052 1285 +233
crontab_main 623 856 +233
ifupdown_main 2202 2403 +201
xvfork - 20 +20
passwd_main 1049 1053 +4
grave 1068 1066 -2
script_main 935 921 -14
vfork_or_die 20 - -20
vfork_compressor 206 175 -31
open_as_user 109 - -109
popen2 218 - -218
edit_file 910 690 -220
run_command 268 - -268
------------------------------------------------------------------------------
(add/remove: 1/4 grow/shrink: 4/4 up/down: 691/-882) Total: -191 bytes
Diffstat (limited to 'miscutils')
| -rw-r--r-- | miscutils/crontab.c | 8 | ||||
| -rw-r--r-- | miscutils/time.c | 4 |
2 files changed, 3 insertions, 9 deletions
diff --git a/miscutils/crontab.c b/miscutils/crontab.c index dc3179dac..4bba9fb44 100644 --- a/miscutils/crontab.c +++ b/miscutils/crontab.c @@ -38,10 +38,8 @@ static void change_user(const struct passwd *pas) static void edit_file(const struct passwd *pas, const char *file) { const char *ptr; - int pid = vfork(); + int pid = xvfork(); - if (pid < 0) /* failure */ - bb_perror_msg_and_die("vfork"); if (pid) { /* parent */ wait4pid(pid); return; @@ -65,9 +63,7 @@ static int open_as_user(const struct passwd *pas, const char *file) pid_t pid; char c; - pid = vfork(); - if (pid < 0) /* ERROR */ - bb_perror_msg_and_die("vfork"); + pid = xvfork(); if (pid) { /* PARENT */ if (wait4pid(pid) == 0) { /* exitcode 0: child says it can read */ diff --git a/miscutils/time.c b/miscutils/time.c index a6d158c53..104548c23 100644 --- a/miscutils/time.c +++ b/miscutils/time.c @@ -372,9 +372,7 @@ static void run_command(char *const *cmd, resource_t *resp) void (*quit_signal)(int); resp->elapsed_ms = monotonic_us() / 1000; - pid = vfork(); /* Run CMD as child process. */ - if (pid < 0) - bb_error_msg_and_die("cannot fork"); + pid = xvfork(); /* Run CMD as child process. */ if (pid == 0) { /* If child. */ /* Don't cast execvp arguments; that causes errors on some systems, versus merely warnings if the cast is left off. */ |