diff options
| author | Denys Vlasenko <vda.linux@googlemail.com> | 2021-06-15 01:42:21 +0200 |
|---|---|---|
| committer | Denys Vlasenko <vda.linux@googlemail.com> | 2021-06-15 01:42:21 +0200 |
| commit | ebe8c14d34d3f6957b4e44967c9089b84e144ddf (patch) | |
| tree | 519d8b4fc2a7214af62af0098a1ec362b1dccb77 | |
| parent | 9e27fed6b9a21454149873cfc4e034c8226f8ffb (diff) | |
udhcpc: do not use inet_addr() to parse -r REQ_IP, it's deprecated
...and we did not error-check it, and this is the only use of it:
function old new delta
inet_addr 37 - -37
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| -rw-r--r-- | networking/udhcp/dhcpc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c index d67f60c00..ab9edd264 100644 --- a/networking/udhcp/dhcpc.c +++ b/networking/udhcp/dhcpc.c @@ -1284,7 +1284,8 @@ int udhcpc_main(int argc UNUSED_PARAM, char **argv) memcpy(p + OPT_DATA + 3, str_F, len); /* do not store NUL byte */ } if (opt & OPT_r) - requested_ip = inet_addr(str_r); + if (!inet_aton(str_r, (void*)&requested_ip)) + bb_show_usage(); #if ENABLE_FEATURE_UDHCP_PORT if (opt & OPT_P) { CLIENT_PORT = xatou16(str_P); |