diff options
author | Denys Vlasenko <dvlasenk@redhat.com> | 2010-08-25 18:26:46 +0200 |
---|---|---|
committer | Denys Vlasenko <dvlasenk@redhat.com> | 2010-08-25 18:26:46 +0200 |
commit | 1cd0d8600524de01d643db32bc05f4d4d0c30436 (patch) | |
tree | 7bdadc6feea96f248ce20059a59f58a7356ca802 | |
parent | 1396221d5a741ef8e1e8abca88836b341a3cab84 (diff) |
modutils: explain why we no longer quote params
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
-rw-r--r-- | modutils/modutils.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/modutils/modutils.c b/modutils/modutils.c index cc718dbca..565d0d22f 100644 --- a/modutils/modutils.c +++ b/modutils/modutils.c @@ -71,6 +71,11 @@ char* FAST_FUNC parse_cmdline_module_options(char **argv) optlen = 0; while (*++argv) { options = xrealloc(options, optlen + 2 + strlen(*argv) + 2); + /* Older versions were enclosing space-containing *argv in "", + * but both modprobe and insmod from module-init-tools 3.11.1 + * don't do this anymore. (As to extra trailing space, + * insmod adds it but modprobe does not. We do in both cases) + */ optlen += sprintf(options + optlen, "%s ", *argv); } return options; |