diff options
author | Matthew Miller <matthew@millerti.me> | 2022-05-18 16:29:30 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-18 16:29:30 -0700 |
commit | c245be34b40c79c798661ce5869b49ec5a964ac3 (patch) | |
tree | 0e45394439b42b0339d4b5a48ac204458e570a69 /packages/server/src | |
parent | c93517488b6efec5c72ff212b834f4c6138ad494 (diff) | |
parent | 97790e8c6f5f00a9875414aee3d4d7ed20f0f437 (diff) |
Merge pull request #203 from MasterKale/fix/authenticator-transports-override
fix/authenticator-transports-override
Diffstat (limited to 'packages/server/src')
4 files changed, 6 insertions, 6 deletions
diff --git a/packages/server/src/authentication/generateAuthenticationOptions.ts b/packages/server/src/authentication/generateAuthenticationOptions.ts index f176835..54a81a3 100644 --- a/packages/server/src/authentication/generateAuthenticationOptions.ts +++ b/packages/server/src/authentication/generateAuthenticationOptions.ts @@ -1,7 +1,7 @@ import type { AuthenticationExtensionsClientInputs, PublicKeyCredentialRequestOptionsJSON, - PublicKeyCredentialDescriptor, + PublicKeyCredentialDescriptorFuture, UserVerificationRequirement, } from '@simplewebauthn/typescript-types'; import base64url from 'base64url'; @@ -9,7 +9,7 @@ import base64url from 'base64url'; import generateChallenge from '../helpers/generateChallenge'; export type GenerateAuthenticationOptionsOpts = { - allowCredentials?: PublicKeyCredentialDescriptor[]; + allowCredentials?: PublicKeyCredentialDescriptorFuture[]; challenge?: string | Buffer; timeout?: number; userVerification?: UserVerificationRequirement; diff --git a/packages/server/src/helpers/convertCertBufferToPEM.test.ts b/packages/server/src/helpers/convertCertBufferToPEM.test.ts index 91c5d6b..9f99128 100644 --- a/packages/server/src/helpers/convertCertBufferToPEM.test.ts +++ b/packages/server/src/helpers/convertCertBufferToPEM.test.ts @@ -20,7 +20,7 @@ dHJpbmcgY2VydEJ1ZmZlclN0cmluZw== }); test('should return pem when input is buffer', () => { - const input = new Buffer(128); + const input = Buffer.alloc(128); const actual = convertCertBufferToPEM(input); const actualPemArr = actual.split("\n"); expect(actual).toEqual(`-----BEGIN CERTIFICATE----- diff --git a/packages/server/src/helpers/toHash.test.ts b/packages/server/src/helpers/toHash.test.ts index de37390..4f012e5 100644 --- a/packages/server/src/helpers/toHash.test.ts +++ b/packages/server/src/helpers/toHash.test.ts @@ -6,6 +6,6 @@ test('should return a buffer of at 32 bytes for input string', () => { }); test('should return a buffer of at 32 bytes for input Buffer', () => { - const hash = toHash(new Buffer(10)); + const hash = toHash(Buffer.alloc(10)); expect(hash.byteLength).toEqual(32); }); diff --git a/packages/server/src/registration/generateRegistrationOptions.ts b/packages/server/src/registration/generateRegistrationOptions.ts index c55b308..f3cf5c2 100644 --- a/packages/server/src/registration/generateRegistrationOptions.ts +++ b/packages/server/src/registration/generateRegistrationOptions.ts @@ -4,7 +4,7 @@ import type { AuthenticatorSelectionCriteria, COSEAlgorithmIdentifier, PublicKeyCredentialCreationOptionsJSON, - PublicKeyCredentialDescriptor, + PublicKeyCredentialDescriptorFuture, PublicKeyCredentialParameters, } from '@simplewebauthn/typescript-types'; import base64url from 'base64url'; @@ -20,7 +20,7 @@ export type GenerateRegistrationOptionsOpts = { userDisplayName?: string; timeout?: number; attestationType?: AttestationConveyancePreference; - excludeCredentials?: PublicKeyCredentialDescriptor[]; + excludeCredentials?: PublicKeyCredentialDescriptorFuture[]; authenticatorSelection?: AuthenticatorSelectionCriteria; extensions?: AuthenticationExtensionsClientInputs; supportedAlgorithmIDs?: COSEAlgorithmIdentifier[]; |