summaryrefslogtreecommitdiffhomepage
path: root/packages/server/src
diff options
context:
space:
mode:
authorMatthew Miller <matthew@millerti.me>2020-07-04 15:49:07 -0700
committerMatthew Miller <matthew@millerti.me>2020-07-04 15:49:55 -0700
commit925e186943694ac1fa60a8b7bf05930e9f1d7263 (patch)
tree40c29ffd39a1d4cbd5d0d40cb67e000276e6c552 /packages/server/src
parent837331f060e6d367bc876a013884cfff617673dc (diff)
Fix bug with enforcing alg be a number
Diffstat (limited to 'packages/server/src')
-rw-r--r--packages/server/src/attestation/verifications/verifyPacked.ts2
-rw-r--r--packages/server/src/attestation/verifyAttestationResponse.ts4
2 files changed, 3 insertions, 3 deletions
diff --git a/packages/server/src/attestation/verifications/verifyPacked.ts b/packages/server/src/attestation/verifications/verifyPacked.ts
index e8be389..977f075 100644
--- a/packages/server/src/attestation/verifications/verifyPacked.ts
+++ b/packages/server/src/attestation/verifications/verifyPacked.ts
@@ -36,7 +36,7 @@ export default async function verifyAttestationPacked(options: Options): Promise
throw new Error('No attestation signature provided in attestation statement (Packed)');
}
- if (Number.isNaN(Number(alg))) {
+ if (typeof alg !== 'number') {
throw new Error(`Attestation Statement alg "${alg}" is not a number (Packed)`);
}
diff --git a/packages/server/src/attestation/verifyAttestationResponse.ts b/packages/server/src/attestation/verifyAttestationResponse.ts
index fe883e6..4ec0a7d 100644
--- a/packages/server/src/attestation/verifyAttestationResponse.ts
+++ b/packages/server/src/attestation/verifyAttestationResponse.ts
@@ -134,8 +134,8 @@ export default async function verifyAttestationResponse(
const decodedPublicKey = decodeCredentialPublicKey(credentialPublicKey);
const alg = decodedPublicKey.get(COSEKEYS.alg);
- if (Number.isNaN(Number(alg))) {
- throw new Error('Credential public key was missing alg');
+ if (typeof alg !== 'number') {
+ throw new Error('Credential public key was missing numeric alg');
}
// Make sure the key algorithm is one we specified within the attestation options