Get rid of “clean” MetadataService state

getStatement() is already capable of returning `undefined` when a statement doesn’t exist for a given aaguid. This means there’s nothing preventing us from using the service without initializing it. By making the service always ready to query for statements by aaguid, it becomes possible to use this library without initializing MetadataService at all if there’s no interest in the additional level of security.

1 files changed, 1 insertions, 6 deletions

diff --git a/packages/server/src/metadata/metadataService.ts b/packages/server/src/metadata/metadataService.ts
index f6f405d..bd86b24 100644
--- a/packages/server/src/metadata/metadataService.ts
+++ b/packages/server/src/metadata/metadataService.ts
@@ -19,7 +19,6 @@ type CachedAAGUID = {
 };
 
 enum SERVICE_STATE {
-  CLEAN,
   REFRESHING,
   READY,
 }
@@ -35,7 +34,7 @@ class MetadataService {
   private nextUpdate: Date = new Date(0);
   private tocAlg = '';
   private tocNo = 0;
-  private state: SERVICE_STATE = SERVICE_STATE.CLEAN;
+  private state: SERVICE_STATE = SERVICE_STATE.READY;
 
   /**
    * Prepare the service to handle live data, or prepared data.
@@ -63,10 +62,6 @@ class MetadataService {
    * as per the `nextUpdate` property in the initial TOC download.
    */
   async getStatement(aaguid: string | Buffer): Promise<MetadataStatement | undefined> {
-    if (this.state === SERVICE_STATE.CLEAN) {
-      throw new Error('MetadataService.initialize() must be called before this method can be used');
-    }
-
     if (!aaguid) {
       return;
     }