summaryrefslogtreecommitdiffhomepage
path: root/packages/server/src
diff options
context:
space:
mode:
authorMatthew Miller <matthew@millerti.me>2020-07-02 23:42:47 -0700
committerMatthew Miller <matthew@millerti.me>2020-07-02 23:42:47 -0700
commit3b9eb08c6a0517820009b4ec0a24bb585f7632af (patch)
tree4c4e5bf65dda992ad43a98924cb0658b37cd106d /packages/server/src
parent09970853cd196e130d4c49026d3d142e56210ac2 (diff)
Clean up some comments
Diffstat (limited to 'packages/server/src')
-rw-r--r--packages/server/src/metadata/metadataService.ts7
1 files changed, 4 insertions, 3 deletions
diff --git a/packages/server/src/metadata/metadataService.ts b/packages/server/src/metadata/metadataService.ts
index 7d8c392..b9be929 100644
--- a/packages/server/src/metadata/metadataService.ts
+++ b/packages/server/src/metadata/metadataService.ts
@@ -121,16 +121,17 @@ class MetadataService {
try {
// Validate the certificate chain
+ // TODO: Check for certificate revocation
validateCertificatePath(fullCertPath);
} catch (err) {
console.error(err);
- // From FIDO MDS docs: "The FIDO Server SHOULD ignore the file if the signature is invalid."
+ // From FIDO MDS docs: "ignore the file if the chain cannot be verified or if one of the
+ // chain certificates is revoked"
return;
}
- // TODO: Figure out why the signature won't verify here
+ // Verify the TOC JWT signature
const leafCert = fullCertPath[0];
-
const verified = KJUR.jws.JWS.verifyJWT(data, leafCert, {
alg: [header.alg],
// Empty values to appease TypeScript and this library's subtly mis-typed @types definitions