diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2016-06-29 22:42:43 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2016-06-29 22:46:45 +0200 |
| commit | 5a137558a6c1e1d7d00dc534534cb4d0d960bab7 (patch) | |
| tree | 5113c704d0dbf9d73d8e0aa4bf1b8cc5f96306e9 | |
| parent | 1a9406e232f945749f57be728720937884050981 (diff) | |
device: remove updating of trans_start
Per http://lists.openwall.net/netdev/2016/05/03/87 dev->trans_start has
been removed, and updates are now supposed to be handled with
netif_trans_update, which now updates the particular txqueue's
trans_start instead.
However, netdev_start_xmit already updates this member after calling
ndo_start_xmit, so the new netif_trans_update function smartly makes the
comment that for drivers that don't use LLTX, it's not neccessary to
call netif_trans_update.
Except we do use LLTX, so it would seem again that we do need to be
calling netif_trans_update. However, glancing at drivers like vxlan and
other similar virtual tunnels, this doesn't seem to be the case. I
suspect the reason is that we both also set IFF_NO_QUEUE, so we aren't
even using a txqueue for updating.
Thus, this patch removes updating of trans_start all together. I believe
this should be okay for older kernels too.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| -rw-r--r-- | src/device.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/device.c b/src/device.c index 4076e58..31fae5b 100644 --- a/src/device.c +++ b/src/device.c @@ -109,8 +109,6 @@ static netdev_tx_t xmit(struct sk_buff *skb, struct net_device *dev) return -ELOOP; } - dev->trans_start = jiffies; - peer = routing_table_lookup_dst(&wg->peer_routing_table, skb); if (unlikely(!peer)) { skb_unsendable(skb, dev); |