From 3dce460c88a84922fdeab246a1b3ebddf796093d Mon Sep 17 00:00:00 2001 From: David Anderson Date: Sun, 1 Mar 2020 00:39:24 -0800 Subject: device: add test to ensure Peer fields are safe for atomic access on 32-bit Adds a test that will fail consistently on 32-bit platforms if the struct ever changes again to violate the rules. This is likely not needed because unaligned access crashes reliably, but this will reliably fail even if tests accidentally pass due to lucky alignment. Signed-Off-By: David Anderson --- device/peer.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'device/peer.go') diff --git a/device/peer.go b/device/peer.go index 8a8224c..19434cd 100644 --- a/device/peer.go +++ b/device/peer.go @@ -27,7 +27,11 @@ type Peer struct { endpoint Endpoint persistentKeepaliveInterval uint16 - // This must be 64-bit aligned, so make sure the above members come out to even alignment and pad accordingly + // These fields are accessed with atomic operations, which must be + // 64-bit aligned even on 32-bit platforms. Go guarantees that an + // allocated struct will be 64-bit aligned. So we place + // atomically-accessed fields up front, so that they can share in + // this alignment before smaller fields throw it off. stats struct { txBytes uint64 // bytes send to peer (endpoint) rxBytes uint64 // bytes received from peer -- cgit v1.2.3