diff options
| author | Josh Bleecher Snyder <josh@tailscale.com> | 2020-12-15 15:02:13 -0800 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-01-07 14:49:44 +0100 |
| commit | 70861686d3005de91b45d38e5b16fd3132a4a872 (patch) | |
| tree | c235b16ab7aae0907f4276feef66239eb820a29b /device/noise-protocol.go | |
| parent | c8faa34cdee37d9bcb588675e2385024bef86c18 (diff) | |
device: fix races from changing private_key
Access keypair.sendNonce atomically.
Eliminate one unnecessary initialization to zero.
Mutate handshake.lastSentHandshake with the mutex held.
Co-authored-by: David Anderson <danderson@tailscale.com>
Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
Diffstat (limited to 'device/noise-protocol.go')
| -rw-r--r-- | device/noise-protocol.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/device/noise-protocol.go b/device/noise-protocol.go index 1dc854f..e34da83 100644 --- a/device/noise-protocol.go +++ b/device/noise-protocol.go @@ -566,7 +566,6 @@ func (peer *Peer) BeginSymmetricSession() error { setZero(recvKey[:]) keypair.created = time.Now() - keypair.sendNonce = 0 keypair.replayFilter.Reset() keypair.isInitiator = isInitiator keypair.localIndex = peer.handshake.localIndex |