WIP: add dhcp addresses to tunnel details

7 files changed, 112 insertions, 16 deletions

diff --git a/tunnel/src/main/java/com/wireguard/android/backend/Dhcp.java b/tunnel/src/main/java/com/wireguard/android/backend/Dhcp.java
new file mode 100644
index 00000000..59a3e69c
--- /dev/null
+++ b/tunnel/src/main/java/com/wireguard/android/backend/Dhcp.java
@@ -0,0 +1,31 @@
+/*
+ * Copyright © 2017-2023 WireGuard LLC. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package com.wireguard.android.backend;
+
+import com.wireguard.config.InetNetwork;
+import com.wireguard.util.NonNullForAll;
+
+import java.util.Set;
+
+/**
+ * Class representing DHCP info for a {@link Tunnel} instance.
+ */
+@NonNullForAll
+public class Dhcp {
+    private Set<InetNetwork> addresses;
+
+    Dhcp(Set<InetNetwork> addresses) {
+        this.addresses = addresses;
+    }
+
+    public Set<InetNetwork> getAddresses() {
+        return addresses;
+    }
+
+    public String toString() {
+        return "DHCP";
+    }
+}
diff --git a/tunnel/src/main/java/com/wireguard/android/backend/GoBackend.java b/tunnel/src/main/java/com/wireguard/android/backend/GoBackend.java
index 00f12bd6..0de07a95 100644
--- a/tunnel/src/main/java/com/wireguard/android/backend/GoBackend.java
+++ b/tunnel/src/main/java/com/wireguard/android/backend/GoBackend.java
@@ -77,6 +77,7 @@ import java.net.UnknownHostException;
 import java.net.URL;
 import java.nio.ByteOrder;
 import java.util.Collections;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Optional;
 import java.util.Set;
@@ -401,8 +402,23 @@ public final class GoBackend implements Backend {
         DhcpResponse resp = stub.dhcp(request);
         Log.i(TAG, "Dhcp: " + resp.getError().getMessage());
 
+        Set<InetNetwork> addresses = new LinkedHashSet<>();
+        if (resp.getLeasesList() != null) {
+            for (final Lease lease: resp.getLeasesList()) {
+                try {
+                    InetAddress addr = InetAddress.getByAddress(lease.getAddress().getAddress().toByteArray());
+                    Log.i(TAG, "Lease: " + addr);
+                    addresses.add(new InetNetwork(addr, 128));
+                } catch (UnknownHostException ex) {
+                    // Ignore
+                }
+            }
+        }
+
+        Dhcp dhcp = new Dhcp(addresses);
+
         // Replace the vpn tunnel
-        final VpnService.Builder builder = getBuilder(currentTunnel.getName(), currentConfig, service, resp.getLeasesList());
+        final VpnService.Builder builder = getBuilder(currentTunnel.getName(), currentConfig, service, dhcp.getAddresses());
 
         Log.i(TAG, "Builder: " + builder);
 
@@ -419,6 +435,7 @@ public final class GoBackend implements Backend {
         service.protect(wgGetSocketV4(currentTunnelHandle));
         service.protect(wgGetSocketV6(currentTunnelHandle));
         Log.i(TAG, "Dhcp done");
+        currentTunnel.onDhcpChange(dhcp);
     }
 
     private int getConnectionOwnerUid(int protocol, InetSocketAddress local, InetSocketAddress remote) {
@@ -503,7 +520,7 @@ public final class GoBackend implements Backend {
         Log.i(TAG, "Exit streamReverse");
     }
 
-    private VpnService.Builder getBuilder(final String name, @Nullable final Config config, final VpnService service, @Nullable final List<Lease> leases) throws PackageManager.NameNotFoundException {
+    private VpnService.Builder getBuilder(final String name, @Nullable final Config config, final VpnService service, @Nullable final Set<InetNetwork> leases) throws PackageManager.NameNotFoundException {
         Log.i(TAG, "Builder 1");
             final VpnService.Builder builder = service.getBuilder();
         Log.i(TAG, "Builder 2");
@@ -519,14 +536,8 @@ public final class GoBackend implements Backend {
 
         Log.i(TAG, "Builder 5");
             if (leases != null) {
-                for (final Lease lease: leases) {
-                    try {
-                        InetAddress addr = InetAddress.getByAddress(lease.getAddress().getAddress().toByteArray());
-                        Log.i(TAG, "Lease: " + addr);
-                        builder.addAddress(addr, 128);
-                    } catch (UnknownHostException ex) {
-                        // Ignore
-                    }
+                for (final InetNetwork lease: leases) {
+                    builder.addAddress(lease.getAddress(), lease.getMask());
                 }
             }
 
diff --git a/tunnel/src/main/java/com/wireguard/android/backend/Tunnel.java b/tunnel/src/main/java/com/wireguard/android/backend/Tunnel.java
index 766df443..6c0f54e3 100644
--- a/tunnel/src/main/java/com/wireguard/android/backend/Tunnel.java
+++ b/tunnel/src/main/java/com/wireguard/android/backend/Tunnel.java
@@ -54,4 +54,11 @@ public interface Tunnel {
             return running ? UP : DOWN;
         }
     }
+
+    /**
+     * React to a change of DHCP of the tunnel. Should only be directly called by Backend.
+     *
+     * @param newDhcp The new DHCP info of the tunnel.
+     */
+    void onDhcpChange(Dhcp newDhcp);
 }
diff --git a/tunnel/src/main/java/com/wireguard/config/InetNetwork.java b/tunnel/src/main/java/com/wireguard/config/InetNetwork.java
index 4a918044..02ccd946 100644
--- a/tunnel/src/main/java/com/wireguard/config/InetNetwork.java
+++ b/tunnel/src/main/java/com/wireguard/config/InetNetwork.java
@@ -20,7 +20,7 @@ public final class InetNetwork {
     private final InetAddress address;
     private final int mask;
 
-    private InetNetwork(final InetAddress address, final int mask) {
+    public InetNetwork(final InetAddress address, final int mask) {
         this.address = address;
         this.mask = mask;
     }
diff --git a/ui/src/main/java/com/wireguard/android/model/ObservableTunnel.kt b/ui/src/main/java/com/wireguard/android/model/ObservableTunnel.kt
index c3e3405e..49e080f9 100644
--- a/ui/src/main/java/com/wireguard/android/model/ObservableTunnel.kt
+++ b/ui/src/main/java/com/wireguard/android/model/ObservableTunnel.kt
@@ -8,6 +8,7 @@ import android.util.Log
 import androidx.databinding.BaseObservable
 import androidx.databinding.Bindable
 import com.wireguard.android.BR
+import com.wireguard.android.backend.Dhcp
 import com.wireguard.android.backend.Statistics
 import com.wireguard.android.backend.Tunnel
 import com.wireguard.android.databinding.Keyed
@@ -55,7 +56,10 @@ class ObservableTunnel internal constructor(
     }
 
     fun onStateChanged(state: Tunnel.State): Tunnel.State {
-        if (state != Tunnel.State.UP) onStatisticsChanged(null)
+        if (state != Tunnel.State.UP) {
+            onStatisticsChanged(null)
+            onDhcpChanged(null)
+        }
         this.state = state
         notifyPropertyChanged(BR.state)
         return state
@@ -137,6 +141,21 @@ class ObservableTunnel internal constructor(
     }
 
 
+    @get:Bindable
+    var dhcp: Dhcp? = null
+        private set
+
+    override fun onDhcpChange(newDhcp: Dhcp) {
+        onDhcpChanged(newDhcp)
+    }
+
+    fun onDhcpChanged(dhcp: Dhcp?): Dhcp? {
+        this.dhcp = dhcp
+        notifyPropertyChanged(BR.dhcp)
+        return dhcp
+    }
+
+
     suspend fun deleteAsync() = manager.delete(this)
 
 
diff --git a/ui/src/main/res/layout/tunnel_detail_fragment.xml b/ui/src/main/res/layout/tunnel_detail_fragment.xml
index aef71e18..d869216e 100644
--- a/ui/src/main/res/layout/tunnel_detail_fragment.xml
+++ b/ui/src/main/res/layout/tunnel_detail_fragment.xml
@@ -142,8 +142,8 @@
                         android:layout_height="wrap_content"
                         android:contentDescription="@string/addresses"
                         android:nextFocusUp="@id/public_key_text"
-                        android:nextFocusDown="@id/dns_servers_text"
-                        android:nextFocusForward="@id/dns_servers_text"
+                        android:nextFocusDown="@id/dhcp_addresses_text"
+                        android:nextFocusForward="@id/dhcp_addresses_text"
                         android:onClick="@{ClipboardUtils::copyTextView}"
                         android:text="@{config.interface.addresses}"
                         android:visibility="@{config.interface.addresses.isEmpty() ? android.view.View.GONE : android.view.View.VISIBLE}"
@@ -152,6 +152,33 @@
                         tools:text="fc00:bbbb:bbbb:bb11::3:368b/128" />
 
                     <TextView
+                        android:id="@+id/dhcp_addresses_label"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:layout_marginTop="8dp"
+                        android:labelFor="@+id/dhcp_addresses_text"
+                        android:text="@string/dhcp_addresses"
+                        android:visibility="@{tunnel.dhcp == null ? android.view.View.GONE : android.view.View.VISIBLE}"
+                        app:layout_constraintStart_toStartOf="parent"
+                        app:layout_constraintTop_toBottomOf="@id/addresses_text" />
+
+                    <TextView
+                        android:id="@+id/dhcp_addresses_text"
+                        style="@style/DetailText"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:contentDescription="@string/dhcp_addresses"
+                        android:nextFocusUp="@id/addresses_text"
+                        android:nextFocusDown="@id/dns_servers_text"
+                        android:nextFocusForward="@id/dns_servers_text"
+                        android:onClick="@{ClipboardUtils::copyTextView}"
+                        android:text="@{tunnel.dhcp.addresses}"
+                        android:visibility="@{tunnel.dhcp == null ? android.view.View.GONE : android.view.View.VISIBLE}"
+                        app:layout_constraintStart_toStartOf="parent"
+                        app:layout_constraintTop_toBottomOf="@+id/dhcp_addresses_label"
+                        tools:text="fc00:bbbb:bbbb:bb11::3:368b/128" />
+
+                    <TextView
                         android:id="@+id/dns_servers_label"
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
@@ -160,7 +187,7 @@
                         android:text="@string/dns_servers"
                         android:visibility="@{config.interface.dnsServers.isEmpty() ? android.view.View.GONE : android.view.View.VISIBLE}"
                         app:layout_constraintStart_toStartOf="parent"
-                        app:layout_constraintTop_toBottomOf="@id/addresses_text" />
+                        app:layout_constraintTop_toBottomOf="@id/dhcp_addresses_text" />
 
                     <TextView
                         android:id="@+id/dns_servers_text"
@@ -168,7 +195,7 @@
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
                         android:contentDescription="@string/dns_servers"
-                        android:nextFocusUp="@id/addresses_text"
+                        android:nextFocusUp="@id/dhcp_addresses_text"
                         android:nextFocusDown="@id/dns_search_domains_text"
                         android:nextFocusForward="@id/dns_search_domains_text"
                         android:onClick="@{ClipboardUtils::copyTextView}"
diff --git a/ui/src/main/res/values/strings.xml b/ui/src/main/res/values/strings.xml
index 865c7f07..7b0174ce 100644
--- a/ui/src/main/res/values/strings.xml
+++ b/ui/src/main/res/values/strings.xml
@@ -105,6 +105,7 @@
     <string name="dark_theme_summary_on">Currently using dark (night) theme</string>
     <string name="dark_theme_title">Use dark theme</string>
     <string name="delete">Delete</string>
+    <string name="dhcp_addresses">DHCP Addresses</string>
     <string name="tv_delete">Select tunnel to delete</string>
     <string name="tv_select_a_storage_drive">Select a storage drive</string>
     <string name="tv_no_file_picker">Please install a file management utility to browse files</string>