diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2018-07-29 16:52:17 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2018-07-29 17:21:30 +0200 |
| commit | 219f4e80166800a9a44f84f9cc097fbed90e225e (patch) | |
| tree | e0dd07d1adb3c632a44a677ca7b348a54e491010 | |
| parent | 6558140a7ca7eda2e39c75cbb587a6f25e3cda4e (diff) | |
MSF: make it more obvious what needs to be done
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| -rw-r--r-- | app/src/main/res/drawable/list_item_background.xml | 9 | ||||
| -rw-r--r-- | app/src/main/res/drawable/list_item_background_anim.xml | 4 |
2 files changed, 9 insertions, 4 deletions
diff --git a/app/src/main/res/drawable/list_item_background.xml b/app/src/main/res/drawable/list_item_background.xml index 28d33737..f82df249 100644 --- a/app/src/main/res/drawable/list_item_background.xml +++ b/app/src/main/res/drawable/list_item_background.xml @@ -1,5 +1,10 @@ <?xml version="1.0" encoding="utf-8"?> <selector xmlns:android="http://schemas.android.com/apk/res/android"> - <item android:drawable="@color/list_item_activated" android:state_activated="true" /> <!-- TODO(msf): themeify this --> - <item android:drawable="@android:color/transparent" /> <!-- TODO(msf): themeify this --> + <!-- TODO(msf): somehow make an additional activated color entry here (or elsewhere?) that + is in use only in multiselect mode, and one that's in use only in ordinary + select mode. In otherwords, we don't want to use the same background color + for both multiselect and normal select (on two column machines). + --> + <item android:drawable="@color/list_item_activated" android:state_activated="true" /> <!-- TODO(msf): get color from theme with ?android/attr: --> + <item android:drawable="@android:color/transparent" /> <!-- TODO(msf): get color from theme with ?android/attr: --> </selector> diff --git a/app/src/main/res/drawable/list_item_background_anim.xml b/app/src/main/res/drawable/list_item_background_anim.xml index 213130c7..8d9ffa42 100644 --- a/app/src/main/res/drawable/list_item_background_anim.xml +++ b/app/src/main/res/drawable/list_item_background_anim.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="utf-8"?> <ripple xmlns:android="http://schemas.android.com/apk/res/android" - android:color="@color/list_item_ripple"> <!-- TODO(msf): themeify this --> + android:color="@color/list_item_ripple"> <!-- TODO(msf): get color from theme with ?android/attr: --> <item android:drawable="@drawable/list_item_background" /> - <item android:id="@android:id/mask" android:drawable="@android:color/white" /> + <item android:id="@android:id/mask" android:drawable="@android:color/white" /> <!-- TODO(msf): get color from theme with ?android/attr: --> </ripple> |