From e7cdb5945775c5807dcb62f01fbcd96436b0ac0c Mon Sep 17 00:00:00 2001 From: Yuichi Ito Date: Wed, 25 Sep 2013 13:59:01 +0900 Subject: packet lib: ipv6: avoid dangerous default value [] as argument Signed-off-by: itoyuichi Signed-off-by: FUJITA Tomonori --- ryu/lib/packet/ipv6.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ryu/lib/packet/ipv6.py b/ryu/lib/packet/ipv6.py index ca5793d1..4131491e 100644 --- a/ryu/lib/packet/ipv6.py +++ b/ryu/lib/packet/ipv6.py @@ -68,7 +68,7 @@ class ipv6(packet_base.PacketBase): return _register_header_type def __init__(self, version, traffic_class, flow_label, payload_length, - nxt, hop_limit, src, dst, ext_hdrs=[]): + nxt, hop_limit, src, dst, ext_hdrs=None): super(ipv6, self).__init__() self.version = version self.traffic_class = traffic_class @@ -78,10 +78,10 @@ class ipv6(packet_base.PacketBase): self.hop_limit = hop_limit self.src = src self.dst = dst - if ext_hdrs: - assert isinstance(ext_hdrs, list) - for ext_hdr in ext_hdrs: - assert isinstance(ext_hdr, header) + ext_hdrs = ext_hdrs or [] + assert isinstance(ext_hdrs, list) + for ext_hdr in ext_hdrs: + assert isinstance(ext_hdr, header) self.ext_hdrs = ext_hdrs @classmethod -- cgit v1.2.3