diff options
| author | YAMAMOTO Takashi <yamamoto@valinux.co.jp> | 2014-02-06 15:47:35 +0900 |
|---|---|---|
| committer | FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> | 2014-02-06 15:57:46 +0900 |
| commit | bda747804b3c27d27709e1e49b5f3a2924af21c5 (patch) | |
| tree | 01aa38f2206d99c77a923e87cd84c8f70ce439d6 | |
| parent | 6973e848677d0f3ece986fbc36bb0b3e8031a88e (diff) | |
ofproto_protocol: fix UnboundLocalError
fix the following crash.
from Yuichi Ito. minor editorialization by me.
> Traceback (most recent call last):
> File "/usr/local/bin/ryu-manager", line 9, in <module>
> load_entry_point('ryu==3.6', 'console_scripts', 'ryu-manager')()
> File "/usr/local/lib/python2.7/dist-packages/ryu/cmd/manager.py", line 73, in main
> services.extend(app_mgr.instantiate_apps(**contexts))
> File "/usr/local/lib/python2.7/dist-packages/ryu/base/app_manager.py", line 368, in instantiate_apps
> self._instantiate(app_name, cls, *args, **kwargs) > File "/usr/local/lib/python2.7/dist-packages/ryu/base/app_manager.py", line 350, in _instantiate
> ofproto_protocol.set_app_supported_versions(cls.OFP_VERSIONS)
> File "/usr/local/lib/python2.7/dist-packages/ryu/ofproto/ofproto_protocol.py", line 40, in set_app_supported_versions
> _versions &= set(vers)
> UnboundLocalError: local variable '_versions' referenced before assignment
Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
| -rw-r--r-- | ryu/ofproto/ofproto_protocol.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/ryu/ofproto/ofproto_protocol.py b/ryu/ofproto/ofproto_protocol.py index cf0495d0..d9ca997b 100644 --- a/ryu/ofproto/ofproto_protocol.py +++ b/ryu/ofproto/ofproto_protocol.py @@ -37,8 +37,10 @@ _supported_versions = set(_versions.keys()) def set_app_supported_versions(vers): - _versions &= set(vers) - assert _versions, 'No OpenFlow version is available' + global _supported_versions + + _supported_versions &= set(vers) + assert _supported_versions, 'No OpenFlow version is available' class ProtocolDesc(object): |