summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorYAMAMOTO Takashi <yamamoto@valinux.co.jp>2014-01-22 13:06:35 +0900
committerFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>2014-01-22 13:16:46 +0900
commitb1b55457486348e810193f1de3f60f1e79f38bc4 (patch)
treeef13030f57dece6d1111662f8e4db0ef6311a80d
parent069bcc72bf0dc0efd18490bce1dcdfd38f9a74e0 (diff)
bgp: comments about notification data
Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
-rw-r--r--ryu/lib/packet/bgp.py22
1 files changed, 11 insertions, 11 deletions
diff --git a/ryu/lib/packet/bgp.py b/ryu/lib/packet/bgp.py
index 8643fa03..ffd332ab 100644
--- a/ryu/lib/packet/bgp.py
+++ b/ryu/lib/packet/bgp.py
@@ -54,11 +54,11 @@ BGP_ERROR_CEASE = 6
# NOTIFICATION Error Subcode for BGP_ERROR_MESSAGE_HEADER_ERROR
BGP_ERROR_SUB_CONNECTION_NOT_SYNCHRONIZED = 1
-BGP_ERROR_SUB_BAD_MESSAGE_LENGTH = 2
-BGP_ERROR_SUB_BAD_MESSAGE_TYPE = 3
+BGP_ERROR_SUB_BAD_MESSAGE_LENGTH = 2 # Data: the erroneous Length field
+BGP_ERROR_SUB_BAD_MESSAGE_TYPE = 3 # Data: the erroneous Type field
# NOTIFICATION Error Subcode for BGP_ERROR_OPEN_MESSAGE_ERROR
-BGP_ERROR_SUB_UNSUPPORTED_VERSION_NUMBER = 1
+BGP_ERROR_SUB_UNSUPPORTED_VERSION_NUMBER = 1 # Data: 2 octet version number
BGP_ERROR_SUB_BAD_PEER_AS = 2
BGP_ERROR_SUB_BAD_BGP_IDENTIFIER = 3
BGP_ERROR_SUB_UNSUPPORTED_OPTIONAL_PARAMETER = 4
@@ -67,19 +67,19 @@ BGP_ERROR_SUB_UNACCEPTABLE_HOLD_TIME = 6
# NOTIFICATION Error Subcode for BGP_ERROR_UPDATE_MESSAGE_ERROR
BGP_ERROR_SUB_MALFORMED_ATTRIBUTE_LIST = 1
-BGP_ERROR_SUB_UNRECOGNIZED_WELL_KNOWN_ATTRIBUTE = 2
-BGP_ERROR_SUB_MISSING_WELL_KNOWN_ATTRIBUTE = 3
-BGP_ERROR_SUB_ATTRIBUTE_FLAGS_ERROR = 4
-BGP_ERROR_SUB_ATTRIBUTE_LENGTH_ERROR = 5
-BGP_ERROR_SUB_INVALID_ORIGIN_ATTRIBUTE = 6
+BGP_ERROR_SUB_UNRECOGNIZED_WELL_KNOWN_ATTRIBUTE = 2 # Data: type of the attr
+BGP_ERROR_SUB_MISSING_WELL_KNOWN_ATTRIBUTE = 3 # Data: ditto
+BGP_ERROR_SUB_ATTRIBUTE_FLAGS_ERROR = 4 # Data: the attr (type, len, value)
+BGP_ERROR_SUB_ATTRIBUTE_LENGTH_ERROR = 5 # Data: ditto
+BGP_ERROR_SUB_INVALID_ORIGIN_ATTRIBUTE = 6 # Data: ditto
# 7 is deprecated RFC 1771 AS Routing Loop
-BGP_ERROR_SUB_INVALID_NEXT_HOP_ATTRIBUTE = 8
-BGP_ERROR_SUB_OPTIONAL_ATTRIBUTE_ERROR = 9
+BGP_ERROR_SUB_INVALID_NEXT_HOP_ATTRIBUTE = 8 # Data: ditto
+BGP_ERROR_SUB_OPTIONAL_ATTRIBUTE_ERROR = 9 # Data: ditto
BGP_ERROR_SUB_INVALID_NETWORK_FIELD = 10
BGP_ERROR_SUB_MALFORMED_AS_PATH = 11
# NOTIFICATION Error Subcode for BGP_ERROR_CEASE (RFC 4486)
-BGP_ERROR_SUB_MAXIMUM_NUMBER_OF_PREFIXES_REACHED = 1
+BGP_ERROR_SUB_MAXIMUM_NUMBER_OF_PREFIXES_REACHED = 1 # Data: optional
BGP_ERROR_SUB_ADMINISTRATIVE_SHUTDOWN = 2
BGP_ERROR_SUB_PEER_DECONFIGURED = 3
BGP_ERROR_SUB_ADMINISTRATIVE_RESET = 4