From 7700c7e033652ed98c0c385b0da936f12b35aabf Mon Sep 17 00:00:00 2001 From: Jeff Forcier Date: Thu, 20 Apr 2023 17:45:08 -0400 Subject: Opt-in overhaul to how MSG_SERVICE_REQUEST is done - New subclass(es) for opt-in use. Most below messages refer to them, not parent classes. - In parent classes, make handler tables instance attributes for easier subclass twiddling. - Refactor Transport-level session check - Refactor Transport-level auth handler instantiation (but keep behavior the same, for now) - Add service-request handler to Transport subclass, and remove from AuthHandler subclass - Remove manual event injection from the handful of Transport auth methods which supported it. Suspect unused, don't need the extra complexity, and wasn't consistent anyways - can add back smarter later if anyone needs it. - Not bothering with gssapi at all for now as I cannot easily test it - Primarily tested against the new AuthStrategy architecture --- tests/test_transport.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/test_transport.py b/tests/test_transport.py index 4062d767..6feccf1d 100644 --- a/tests/test_transport.py +++ b/tests/test_transport.py @@ -1099,7 +1099,8 @@ class TransportTest(unittest.TestCase): def test_server_transports_reject_client_message_types(self): # TODO: handle Transport's own tables too, not just its inner auth # handler's table. See TODOs in auth_handler.py - for message_type in AuthHandler._client_handler_table: + some_handler = AuthHandler(self.tc) # kludge to get _some_ AH instance + for message_type in some_handler._client_handler_table: self._send_client_message(message_type) self._expect_unimplemented() # Reset for rest of loop -- cgit v1.2.3