Age | Commit message (Collapse) | Author |
|
Plus related twiddling of test key files
|
|
Migrate rest of existing agent tests to new module
Also make them better.
Also fix AttributeError raising to not be py3.10 specific
|
|
|
|
|
|
|
|
|
|
This was previously only done in SSHClient.
It's not relevant for from_type_string which is aimed at ssh-agents,
which tend to do their own cert loading where necessary
|
|
- Merge them but also break them up. It's complicated.
- Move cert files into _support
- Related comments in the source as some of this is non-intuitive
|
|
Also includes more rearranging of AuthHandler related tests
|
|
Also move auth tests to be new style filename, obj naming
Also allow test task module selector to see new-style test modules
|
|
|
|
This file location/name is a GitHub-honored convention, and I've set up
my local clone with `git config blame.ignoreRevsFile
.git-blame-ignore-revs` to match.
|
|
|
|
|
|
Phrased in a it-passes-now fashion, but once fixed in main code path,
will need changing of course.
|
|
|
|
distributed
|
|
|
|
Main branch as of today:
350 passed, 21 skipped, 52 deselected, 3 warnings in 11.10s
This branch as of this commit:
361 passed, 21 skipped, 52 deselected, 3 warnings in 10.51s
Of those 11 "new" tests, 8 are ones I wrote (tests/pkey.py). Hard to
figure out what the other 3 are given pytest-relaxed's output is very
different from regular verbose pytest. oops.
|
|
|
|
- New subclass(es) for opt-in use. Most below messages refer to them,
not parent classes.
- In parent classes, make handler tables instance attributes for easier
subclass twiddling.
- Refactor Transport-level session check
- Refactor Transport-level auth handler instantiation (but keep behavior
the same, for now)
- Add service-request handler to Transport subclass, and remove from
AuthHandler subclass
- Remove manual event injection from the handful of Transport auth
methods which supported it. Suspect unused, don't need the extra
complexity, and wasn't consistent anyways - can add back smarter later
if anyone needs it.
- Not bothering with gssapi at all for now as I cannot easily test it
- Primarily tested against the new AuthStrategy architecture
|
|
- Comment was being read-but-not-stored from the agent reply. wat?
- Use newly added PKey constructor to instantiate a key subclass for the
'inner'/proxied key, this way client code can obtain stuff like bit
size, fingerprint, etc.
- Proxy to inner_key with __getattr__ so clients don't have to know
whether they're dealing with an AgentKey or a regular one
- Add `__repr__` to PKey instead of doing it in AgentKey. (wow, how did
we not have this ever?)
|
|
- add .name to eventually replace .get_name
- use that in a bunch of spots to avoid some duplication
- add .identifiers classmethod to extend existing idea from ECDSAKey
- add from_type_string alt constructor which uses .identifiers
- use that in HostKeys (includes hopefully-minor refactoring)
- no longer giving outdated init kwarg to ECDSA host key loading
|
|
This was added for #2173 but seemingly in its initial pass, before the
submitter realized two spaces is _not_ a valid separator.
It accidentally passed the tests due to how HostKeys.from_line was
implemented at the time (two spaces -> 'key type' was misread and an
empty string -> empty string not a valid key type -> returns None).
An impending rewrite of that method turned this up.
|
|
This seems likely a missed spot from the Python 3 conversion or the
Python 2 drop.
|
|
|
|
|
|
|
|
|
|
|
|
Requires an inflight set of changes to invocations
|
|
|
|
|
|
Closes #2226
|
|
|
|
|
|
|
|
|
|
|
|
Expand documentation on server agent handling.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|