summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorOlle Lundberg <geek@nerd.sh>2014-08-15 12:22:31 +0200
committerOlle Lundberg <geek@nerd.sh>2014-08-15 12:22:31 +0200
commit6fe52ccac45f527ced2d4dc3f2d4911f9db7a396 (patch)
tree7464f376aa26f0cdea9a6796066c9ccd4c612db2
parentf88189835eebab72a3792f67de4aacc7fca68df6 (diff)
Document potential brokeness.
-rw-r--r--paramiko/channel.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/paramiko/channel.py b/paramiko/channel.py
index 583809d5..a7d71212 100644
--- a/paramiko/channel.py
+++ b/paramiko/channel.py
@@ -683,6 +683,9 @@ class Channel (object):
self.lock.acquire()
try:
size = self._wait_for_send_window(size)
+ # Instead of returning 0 here when the channel is closed, we might
+ # want to raise EOFError or similar. Should we just do as in the
+ # send_all method, raise a socket.error?
if size == 0:
# eof or similar
return 0
@@ -718,6 +721,9 @@ class Channel (object):
self.lock.acquire()
try:
size = self._wait_for_send_window(size)
+ # Instead of returning 0 here when the channel is closed, we might
+ # want to raise EOFError or similar. Should we just do as in the
+ # send_all method, raise a socket.error?
if size == 0:
# eof or similar
return 0