summaryrefslogtreecommitdiff
path: root/utils.c
diff options
context:
space:
mode:
authorHauke Mehrtens <hauke@hauke-m.de>2019-06-16 22:24:36 +0200
committerHauke Mehrtens <hauke@hauke-m.de>2019-06-16 22:41:26 +0200
commit91fcac34ac014a565fdd6312de088d312b5ba7ec (patch)
tree3b7b812cdb229877f8c1bf11330abf620e7e39d0 /utils.c
parentcdfc902a4cb77bc538a729f9e1c8a8578454a0e5 (diff)
uhttpd: Fix multiple format string problems
After format string checks were activated in libubox the compiler started to complain about multiple missuses in uhttpd. This fixes the format strings without changing the behavior. blobmsg_get_string() just checks if the parameter is not NULL and then calls blobmsg_data() and casts the result. I think non of these problem is security relevant. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Diffstat (limited to 'utils.c')
-rw-r--r--utils.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/utils.c b/utils.c
index d990d7d..142a410 100644
--- a/utils.c
+++ b/utils.c
@@ -47,7 +47,7 @@ void uh_chunk_write(struct client *cl, const void *data, int len)
ustream_printf(cl->us, "%X\r\n", len);
ustream_write(cl->us, data, len, true);
if (chunked)
- ustream_printf(cl->us, "\r\n", len);
+ ustream_printf(cl->us, "\r\n");
}
void uh_chunk_vprintf(struct client *cl, const char *format, va_list arg)
@@ -74,7 +74,7 @@ void uh_chunk_vprintf(struct client *cl, const char *format, va_list arg)
ustream_write(cl->us, buf, len, true);
else
ustream_vprintf(cl->us, format, arg);
- ustream_printf(cl->us, "\r\n", len);
+ ustream_printf(cl->us, "\r\n");
}
void uh_chunk_printf(struct client *cl, const char *format, ...)