diff options
| author | Hauke Mehrtens <hauke@hauke-m.de> | 2019-09-02 22:29:49 +0200 |
|---|---|---|
| committer | Hans Dedecker <dedeckeh@gmail.com> | 2019-09-03 21:38:43 +0200 |
| commit | d818380fb6db3401c204a7cdb66af9e5ccc7693b (patch) | |
| tree | 5ea3a468c8b727375af935e369a8e784d179a271 | |
| parent | 94a1c942315f6b3c2870cf744114bb133f209799 (diff) | |
odhcpd: router: Fix out of scope memory access
A pointer to search_buf is accessed by search_domain outside of the
if branch which defines search_buf. The compiler could already reuse
this memory.
Coverity: #1445747
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
| -rw-r--r-- | src/router.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/router.c b/src/router.c index 07dd146..700e1ff 100644 --- a/src/router.c +++ b/src/router.c @@ -607,6 +607,7 @@ static int send_router_advert(struct interface *iface, const struct in6_addr *fr struct in6_addr dns_pref, *dns_addr = NULL; size_t dns_cnt = 0, search_len = iface->search_len; uint8_t *search_domain = iface->search; + uint8_t search_buf[256]; /* DNS Recursive DNS */ if (iface->dns_cnt > 0) { @@ -630,8 +631,6 @@ static int send_router_advert(struct interface *iface, const struct in6_addr *fr /* DNS Search options */ if (!search_domain && !res_init() && _res.dnsrch[0] && _res.dnsrch[0][0]) { - uint8_t search_buf[256]; - int len = dn_comp(_res.dnsrch[0], search_buf, sizeof(search_buf), NULL, NULL); if (len > 0) { |