summaryrefslogtreecommitdiffhomepage
AgeCommit message (Collapse)Author
2015-02-17netifd: Set interface device config when device has old settingsHans Dedecker
If interface device settings are removed in UCI they were not removed in the device settings; calling device_set_config when device settings are present solves this. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2015-02-17netifd: Keep reference to a config copy in device type specific reload ↵Hans Dedecker
handler as the original config pointer might go stale Fixes random observed crashes in blobmsg_parse when device type specific config data is parsed. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2015-02-17netifd: Fix possible hotplug race conditionsHans Dedecker
Don't drop ifup/ifdown events in case an interface event is cached as it leads to possible race conditions (eg firewall not being reloaded as ifup is dropped) when multiple interface events are fired in a short timeframe (eg multiple PPP link flaps). Always overwrite the cached interface event except for the interface update event so the hotplug scripts are launched with the last known status. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2015-02-16utils.c: add missing includeFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-02-16Revert "interface: do not set device_config where only the ifname option ↵Felix Fietkau
matches" This reverts commit 8dd2eedafccc9f898d391b93a59efb1412c5b5e9. This commit was reported to cause a regression with setting MTU on interfaces. Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-02-09netifd: Add option to configure base_reachable_time_ms for each deviceHans Dedecker
The UCI parameter neighreachabletime allows to control the hardware address to IP mapping lifetime in the neighbour table for both IPv4 and IPv6 Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> Signed-off-by: Jean-Francois Remy <jeff@melix.org>
2015-02-09netifd: Remove unnecessary default_config check in config_parse_interfaceHans Dedecker
No need to check default_config twice as it's already checked in config_parse_interface Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2015-02-09netifd: set current_config for simple devices when parsing device configHans Dedecker
If currrent_config is not set when the simple device config is applied the device will be deleted in device_reset_old Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2015-01-24Revert "vlan: reset device state on init"Felix Fietkau
This is causing a regression with some VLAN configurations This reverts commit a4445215e06ee3056427effbef617f4525ee1836.
2015-01-24device: force changes to be applied via state change if necessaryFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-24interface: suppress unnecessary device config overridesFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-24interface: apply device config passed through interface configFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-24device: simplify config blob memory allocation handlingFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-24interface: do not set device_config where only the ifname option matchesFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-24vlan: reset device state on initFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-24device: apply config changes from device sectionsFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-24device: move config apply handling to a helper functionFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-23device: set dev->default_config to false for devices parsed from configFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-23device: add support for specifying a configuration for simple vlan devicesFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-23bridge: fix retrying member enable when the bridge is otherwise emptyFelix Fietkau
Ensure that the bridge gets created before retrying Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-23bridge: mark tested members as present during enable retryFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-23bridge: release failed member devicesFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2015-01-19netifd: Make interface identifier of delegated IPv6 address configurableHans Dedecker
The ip6ifaceid UCI interface parameter makes the interface identifier of the delegated IPv6 address configurable. The parameter can have the following values: eui64 : Interface identifier is generated from the interface's MAC address random : Interface identifier is generated randomly fixed value : Interface identifier is a fixed value (eg ::1:2) The latter is the default value with a fixed value of ::1 for backwards compatibility Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> Signed-off-by: Joeri Barbarien <joeri.barbarien@gmail.com>
2014-12-23handler: replace calls to deprecated json_object_object_getSteven Barth
Signed-off-by: Steven Barth <steven@midlink.org>
2014-12-23netifd: Add mldversion config supportSteven Barth
Config support to set the MLD host version on device level; possible values are : 1 : MLDv1 2 : MLDv2 Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> Cleaned up and simplified. Signed-off-by: Steven Barth <steven@midlink.org>
2014-12-23netifd: Handle link down event in interface setup state as wellHans Dedecker
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-12-08Enable callers to pass the source IP of an IPv4 route when usingKristian Evensen
proto_add_ipv4_route(). This is useful with for example DHCP in a multihomed scenario, as it provides an easy way to match default routes with the correct IP address. One use case for this are applications that monitor the state of the WAN port, and the WAN port is assigned multiple addresses. Signed-off-by: Kristian Evensen <kristian.evensen at gmail.com>
2014-12-08netifd: Add igmpversion config supportHans Dedecker
Config support to set the IGMP host version on device level; possible values are : 1 : IGMPv1 2 : IGMPv2 3 : IGMPv3 Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> Cleand up and simplified Signed-off-by: Steven Barth <steven@midlink.org>
2014-12-08netifd: Fix interface auto disable when doing network reloadHans Dedecker
Keep interface down when interface auto parameter is set to 0 when doing network reload Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-12-08netifd: Make possible state transitions more clear when handling teardown eventHans Dedecker
Improve code readibility regarding state transitions when handling teardown event Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-12-08netifd: Fix proto shell setup/teardwon race conditionHans Dedecker
Fix setup race condition when proto shell is in teardown or setup_abort state when setup cmd is received. Don't change the proto shell state and launch no setup in these conditions so the proto shell teardown timeout handler does not kill the wrong processes and proto_shell_task_finish takes action on the correct teardown state. Don't launch a new setup action when already in setup state. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-12-08netifd: Fix restore of original device settingsHans Dedecker
Don't restore original device settings based on the device settings flags in system_if_down as device flags are already reset when the device config is deleted. Therefore move the masking of the relevant original device settings to system_if_up. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-11-27netifd v2: Fix source routing for IPv4Kristian Evensen
According to the OpenWRT Network documentation for route, the 'source' option is "The preferred source address when sending to destinations covered by the target". However, netifd currently stores this value in RTA_SRC on NEWROUTE/DELROUTE. RTA_SRC is not used by kernel when handling NEWROUTE nor DELROUTE for IPv4 routes. When adding a new IPv4 route, the source is stored in RTA_PREFSRC and the option works as specified in documentation. For IPv6, the address is still stored in RTA_SRC as to not break source-destination routing for IPv6. v2: Limit patch to IPv4, to prevent breaking IPv6 configurations (thanks Steven Barth) Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com>
2014-11-25Fix setting blackhole-routes to kernelSteven Barth
Signed-off-by: Steven Barth <steven@midlink.org>
2014-11-23bridge: retry adding members after config reload / device startFelix Fietkau
The kernel will refuse to add a vlan device to a bridge when the base device of that vlan is already a member. This can happen on config reload. Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2014-11-19netifd: Add acceptlocal config supportHans Dedecker
Adds support to accept packets with local source address. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-11-19netifd: Add rpfilter config supportHans Dedecker
Reverse path filtering config support; possible values are: 0: no source validation 1|strict: strict mode as packet will be dropped if the incoming interface is not the best reverse path 2|loose: loose mode as packet will be dropped if the source address is not reachable via any interface Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-11-19netifd: Remove superfluous system_if_resolve callsHans Dedecker
Don't resolve the ifindex of the parent device again when adding vlandev and macvlan devices as the ifindex has already been resolved. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-11-19netifd: Fix device ifindex overwrite when processing netlink event messagesHans Dedecker
When a device with the same name is deleted and created again in the kernel the ifindex changes. A race condition will occur when netlink event messages linked to the old device are processed and will thus overwrite the correct ifindex of the new device. Further make sure a valid ifindex is in place for both external and internal devices when setting the state to enabled. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-10-24netifd : Apply interface metric on subnet routes when reloading ipHans Dedecker
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-10-24netifd : Reinsert ip parameters (addresses/routes) based on old interface ↵Hans Dedecker
config state Reinserts the config IP parameters as the config_ip parameter of the new interface is set to false in interface_alloc and thus not loading the config ip options of the old interface Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-10-24netifd: Read current link state when processing netlink eventHans Dedecker
Netifd commit b2dcb02570939d98b92c7c55db1c328693a5d52a introduces a race condition resulting into infinite toggling interfaces (eg static interfaces with linksensing enabled, vlan interfaces with proto none (#18106)) when linksensing is enabled resulting into a crash. As netlink event messages will be queued on the netlink event socket the included lower up interface flag will not always represent the current link state when netifd processes the netlink messages; by reading the current link state when a netlink event message is parsed the correct info is passed to the device layer. This will avoid continuous interface toggling (down/up) triggered by link state changes based on outdated netlink interface info. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-10-24wireless: use strdup for vif sectionsFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2014-10-24system-linux: fix a glob related memleakFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2014-10-24config: use sprintf instead of asprintfFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2014-10-20device: make link status detection optional for vlan devicesFelix Fietkau
Fixes a race condition that triggers endless link loss / detect calls when VLAN devices are created. Signed-off-by: Felix Fietkau <nbd@openwrt.org>
2014-10-16proto-shell: fix for not handling switch from DHCP to static raceMichel Stam
When a shell script call is finished, proto_shell_task_finish( ) is called to monitor processes, and determine the next interface state. When the interface is brought up after a reconfiguration from dhcp to static, it will first try to (erroneously?) reconfigure the interface for DHCP. Upon doing this, it realises the mistake and kills off the script by setting the state to S_SETUP_ABORT. This is done by the proto_shell_handler. When this happens. the scripts have 1 second to finish. When this happens, S_SETUP_ABORT in proto_shell_task_finish( ) should issue a 'teardown' event to the shell script to deconfigure the interface. It is here that things go wrong. Shell scripts do not execute commands themselves, they should finish as quick as possible. This is very race condition sensitive, though; Instead of executing commands, they post messages to execute commands. It is therefore possible that when the script finishes, there's still commands to execute. The dhcp protocol handler script, one of the scripts involved, notifies netifd of changes by (indirectly) calling proto_shell_update_link( ). Once every so often, the dhcp script will not be finished in time, and proto_shell_task_finish( ) cannot immediately continue, because (in this case) the proto_task is still pending. If this happens, the proto_shell_task_finish( ) will wait, but if the proto_shell_update_link( ) notification is then received, it will set the statemachine to idle, thus breaking the S_SETUP_ABORT. Furthermore, an event is generated to indicate that the network interface should be set to UP, rather than DOWN. This confuses netifd, and the result is a stuck process that does not respond to UCI calls anymore. Note that a similar situation happens in the S_TEARDOWN state in proto_shell_task_finish( ). The fix, although a bit ugly, is to prevent the UP event from being sent, and not to reset the state machine to idle in proto_shell_update_link( ). Signed-off-by: Michel Stam <m.stam@fugro.nl>
2014-10-12netifd: Fix lost interface device config for devices having default configHans Dedecker
As the PPP main device (either a simple or old style vlan device) is freed when PPP interfaces are reloaded; interface device specific config (eg mtu/macaddr/...) is lost as the interface config is not re-applied on the newly created device. Patch fixes the issue by re-applying the interface device config after the main device is claimed and is having default config. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-10-12netifd : Line up device.h include guardHans Dedecker
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
2014-10-07config: define _GNU_SOURCE for asprintfFelix Fietkau
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-02 19:01:34 +0000