summaryrefslogtreecommitdiffhomepage
path: root/tunnel.c
diff options
context:
space:
mode:
authorHans Dedecker <dedeckeh@gmail.com>2016-02-01 10:56:18 +0100
committerFelix Fietkau <nbd@openwrt.org>2016-02-01 11:09:57 +0100
commit18aa062d491988d6fa15092b7ed92cc6f9e44b6d (patch)
tree354d5b17b2783e8b3553ee19a069c26ce47128a7 /tunnel.c
parent1eac490bd39bcf8b48795fe0555b4451ba2bf1dd (diff)
tunnel: Fix uninitialized access
Fix tb_dev uninitialized access by device_init_settings Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Diffstat (limited to 'tunnel.c')
-rw-r--r--tunnel.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/tunnel.c b/tunnel.c
index aa670a3..524fd43 100644
--- a/tunnel.c
+++ b/tunnel.c
@@ -49,12 +49,11 @@ tunnel_reload(struct device *dev, struct blob_attr *attr)
if (uci_blob_check_equal(dev->config, attr, cfg))
return DEV_CONFIG_NO_CHANGE;
- if (attr) {
- memset(tb_dev, 0, sizeof(tb_dev));
+ memset(tb_dev, 0, sizeof(tb_dev));
+ if (attr)
blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
blob_data(attr), blob_len(attr));
- }
device_init_settings(dev, tb_dev);