diff options
| author | Hans Dedecker <dedeckeh@gmail.com> | 2015-11-02 11:16:12 +0100 |
|---|---|---|
| committer | Steven Barth <steven@midlink.org> | 2015-11-04 01:12:25 +0100 |
| commit | 4902ba2999dec02e82066d70ab6096b852a33007 (patch) | |
| tree | 04ceb89fb4497849162a056664379fd3d75f2971 /system-linux.c | |
| parent | fa64fe118945127007fc6f6f558d0630258790bd (diff) | |
device: Don't process link events anymore in device user specific callback handlers
Set link_state for all device types via the device_set_link API as all devices are registered
in the device tree list making it possible to always get the device via device_get.
The decice link state parameter will now actually reflect the corresponding kernel device
carrier state in all cases.
Before this change a vlan/macvlan device could still have link_state enabled if an interface
was brought down; this was the case when the parent vlan/macvlan device was still enabled as
the netlink link_state event would be dropped for vlan/macvlan devices due to keep_link_state
in the function cb_rtnl_event.
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Diffstat (limited to 'system-linux.c')
| -rw-r--r-- | system-linux.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/system-linux.c b/system-linux.c index 611acb8..4ccc9d2 100644 --- a/system-linux.c +++ b/system-linux.c @@ -424,7 +424,7 @@ static int cb_rtnl_event(struct nl_msg *msg, void *arg) goto out; struct device *dev = device_get(nla_data(nla[IFLA_IFNAME]), false); - if (!dev || dev->type->keep_link_status) + if (!dev) goto out; if (!system_get_dev_sysctl("/sys/class/net/%s/carrier", dev->ifname, buf, sizeof(buf))) |